Update gaia imports to check if it has marionette_driver package, if not use marionette still

RESOLVED FIXED

Status

defect
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

({pi-marionette-client, pi-marionette-goal})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [marionette=1.0])

Attachments

(1 attachment)

Assignee

Description

5 years ago
This allows us to break things up into modular parts and makes things easier to ship
Assignee

Updated

5 years ago
Priority: -- → P1
Whiteboard: [marionette=1.0]
Assignee

Comment 1

5 years ago
Assignee: nobody → dburns
Attachment #8546942 - Flags: review?(dave.hunt)
Comment on attachment 8546942 [details] [review]
PR 27288: handle new marionette import

Sorry for the delay in getting to this. It's quite an extensive change, and I'm guessing that it will be temporary - ultimately moving over to the marionette_driver package once it's available. I wonder if there's a way to do this in one go without the try/except? Could we release a new version of marionette-client with marionette_driver available? Then a future release would remove this in favour of the separately installable package?
Attachment #8546942 - Flags: review?(dave.hunt)
Assignee

Comment 3

5 years ago
Currently I can't land marionette_driver, therefore release it, because it is failing gaiatests on treeherder. I think having the try/except allows us to upgrade everything everywhere and then release and if people don't update then it uses one or other and we can notify that in the next release they MUST update. 

At some point we are going to have to update the gaiatests to use marionette_driver package, I think this way does it nicely and people won't be aware of it when it first lands.
Flags: needinfo?(dave.hunt)
Couldn't the current marionette client offer a marionette_driver package that essentially just masquerades as the marionette package? That way you could just switch to marionette_driver before the separate driver package is ready to ship. I just think a try/except for every file is a little ugly, but if you don't feel like we can avoid it then let's continue with this approach.

I think a test maintainer would be better to review this patch though, as it will affect imports for any patches in review or to be written. Also, this will rot quickly so will need some coordination to land it.
Flags: needinfo?(dave.hunt)
Assignee

Updated

5 years ago
Attachment #8546942 - Flags: review?(florin.strugariu)
Comment on attachment 8546942 [details] [review]
PR 27288: handle new marionette import

Except for the 2 non-blocking nits all looks OK to me.
Attachment #8546942 - Flags: review?(florin.strugariu) → review+
You need to log in before you can comment on or make changes to this bug.