Move the new logviewer icon to webapp/app/img

VERIFIED FIXED

Status

Tree Management
Treeherder
P1
minor
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In the course of fixing bug 1057349, I created a variant .svg icon licensed under Creative Commons from http://flaticon.com.

I originally put it in a new folder, webapp/app/vendor/img/. Mauro would prefer it live with all the other icons in webapp/app/img/ so we don't need to add another entry to the manifest during grunt builds and pushes to the instances.

So this change will do that move, assuming everyone is ok with CC licensed icons co-mingling with our own. I am not sure how we will differentiate between the two types in the dir going forward though, other than I suppose tracing their git history.

We will still keep the CC footer in Help, which refers to use of CC icons.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
P1 since stage gets:
GET https://treeherder.allizom.org/vendor/img/logviewerIcon.svg [HTTP/1.1 404 NOT FOUND 172ms]
Priority: P4 → P1
(Assignee)

Comment 2

4 years ago
Created attachment 8544746 [details] [review]
treeherder-ui-PR#329

Please see above PR for status and review.
Attachment #8544746 - Flags: review?(mdoglio)
Attachment #8544746 - Flags: review?(mdoglio) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/07035ac49cf73bbdb679392f76b3c393ab58abbe
Bug 1118384 - Move the new logviewer icon to webapp/app/img

https://github.com/mozilla/treeherder-ui/commit/468ad3d936fcd6c1c3e974b5f1117608d4ed300a
Merge pull request #329 from tojonmz/move-logviewericon

Bug 1118384 - Move the new logviewer icon to webapp/app/img
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

4 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/871e6c34f2dbcb29e44ec30de19e1c3234ffff00
Bug 1118384 - Move the new logviewer icon to webapp/app/img

https://github.com/mozilla/treeherder/commit/caf2bb22d5316f52d0b1b449516755687a2028d8
Merge pull request #329 from tojonmz/move-logviewericon

Bug 1118384 - Move the new logviewer icon to webapp/app/img
You need to log in before you can comment on or make changes to this bug.