Closed
Bug 1118401
Opened 9 years ago
Closed 9 years ago
Use https:// for linkification of CVEs and VCS-related output
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: reed, Assigned: reed)
Details
Attachments
(1 file, 1 obsolete file)
|
3.82 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Should use https:// for all the linkification of things....
Attachment #8544756 -
Flags: review?(dkl)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8544756 [details] [diff] [review] patch - v1 Review of attachment 8544756 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/BMO/t/bug_format_comment.t @@ +27,5 @@ > # CVE/CAN security things > CVE-2014-0160 > +CVE-2014-0001 > +CVE-2014-13579 > +CVE-2014-999999999 Need to add test cases for the additional lines. @@ +75,5 @@ > + '<a href="https://viewvc.svn.mozilla.org/vc?view=rev&revision=2424">r2424</a>', > + '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github] withuri -> withuri</a>', > + '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github] nouri -> nouri</a>', > + '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github] nologin -> nologin</a>', > + 'https://bzr.mozilla.org/bmo/4.2/revision/9257', Not an issue with this patch but a bug in the test script from prior. Might as well fix it as part of this commit. Please s/a=commit/a=commitdiff/
Attachment #8544756 -
Flags: review?(dkl) → review-
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8544756 -
Attachment is obsolete: true
Attachment #8544805 -
Flags: review?(dkl)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8544805 [details] [diff] [review] patch - v2 Review of attachment 8544805 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=dkl
Attachment #8544805 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 7bbb242..ce356db master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
This is live now.
|
||
Updated•5 years ago
|
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•