1118401 - Use https:// for linkification of CVEs and VCS-related output

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

Should use https:// for all the linkification of things....

Comment 1

[David Lawrence [:dkl]]

Comment on attachment 8544756 [details] [diff] [review]
patch - v1

Review of attachment 8544756 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/BMO/t/bug_format_comment.t
@@ +27,5 @@
>  # CVE/CAN security things
>  CVE-2014-0160
> +CVE-2014-0001
> +CVE-2014-13579
> +CVE-2014-999999999

Need to add test cases for the additional lines.

@@ +75,5 @@
> +    '<a href="https://viewvc.svn.mozilla.org/vc?view=rev&amp;revision=2424">r2424</a>',
> +    '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github]  withuri -> withuri</a>',
> +    '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github]  nouri -> nouri</a>',
> +    '<a href="https://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=eab44b1">36f56bd..eab44b1 [github]  nologin -> nologin</a>',
> +    'https://bzr.mozilla.org/bmo/4.2/revision/9257',

Not an issue with this patch but a bug in the test script from prior. Might as well fix it as part of this commit.

Please s/a=commit/a=commitdiff/

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8544805 [details] [diff] [review]
patch - v2

Review of attachment 8544805 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl

Comment 4

[Reed Loden [:reed]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   7bbb242..ce356db  master -> master

Comment 5

[David Lawrence [:dkl]]

This is live now.