Closed Bug 1118537 Opened 6 years ago Closed 2 years ago

html5_player::HTML5Player::is_playing() is incomplete per HTML5 Video spec

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: gmealer, Unassigned)

References

()

Details

Currently, is_playing() just checks the paused attribute of the video element and returns True if that attribute is false.

http://www.w3.org/TR/html5/embedded-content-0.html#potentially-playing

...is clear that whether playback has ended must also be considered. 

At the very least, we should check the ended attribute as well, since it's updated very soon after the "playback ended" criteria are met.
QA Whiteboard: [fxosqa-auto-backlog+]
Summary: html5_player::HTML5Player::is_playing() is incomplete per Media spec → html5_player::HTML5Player::is_playing() is incomplete per HTML5 Video spec
This is regarding the test_browser_play_video.py test. I can take this.
Yes, if the video would end before this gaia-ui test is finished, it could lead to failures, so we should take "playback ended" into consideration.
Although, the test seems to be stable, nowadays.
Assignee: nobody → martijn.martijn
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-backlog+][fxosqa-auto-s8]
QA Whiteboard: [fxosqa-auto-backlog+][fxosqa-auto-s8] → [fxosqa-auto-backlog+]
Blocks: 1120483
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s8]
Assignee: martijn.martijn → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.