Closed Bug 1118564 Opened 10 years ago Closed 6 years ago

[FFOS7715 v2.1] what is useful of function waitForNextPaint, could we remove it if has remove switch animation ?

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ben.song, Unassigned)

References

Details

      No description provided.
Dear All,

Because of performence problem, we need to analysis time consuming of app hot start-up and exit.

We find the code of waitForNextPaint would consume a lot of it, so we want to know the useful of this function.If we have removed app open and close animation, could we remove this asynchronous operation?

Please help me with this problem, Thanks.
Flags: needinfo?(vchen)
Flags: needinfo?(sku)
Flags: needinfo?(lchang)
Flags: needinfo?(alive)
Alive is the expertise here, Alive, could you kindly share some insights for this one?

Thanks
Flags: needinfo?(vchen)
Flags: needinfo?(sku)
Flags: needinfo?(lchang)
I would say yes if you don't care about animation. We could remove the check on low end device.
Flags: needinfo?(alive)
Flags: needinfo?(ben.song)
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> I would say yes if you don't care about animation. We could remove the check
> on low end device.

Dear Alive,

OK, thanks, we would check remove it is or not bring other problem.
Flags: needinfo?(ben.song)
Dear Alive,

Base on reducing the time of hot back, we have removed the animation of app transition, and reduce the timeout of waitForNextPaint function from 500ms to 100ms for it consuming too much time.

But after this, while we back to homescreen, the screen would flash and reflow for 0.2 or 0.3s, it would bring bad experience of users and the time not be reduced.

So could we let homescreen not reflow in waitForNextPaint or the end of switching ?
Flags: needinfo?(alive)
Dear Alive,

What does the iframe have do while screen reflow or during waitforNextPaint ? Is the icon pictures's pixels too high or not ?

Thanks.
It is just the side effect that you did not let the incoming app to redraw before seeing it. So please check if (this.isHomescreen) in your hack to reduce anything.
Flags: needinfo?(alive)
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7)
> It is just the side effect that you did not let the incoming app to redraw
> before seeing it. So please check if (this.isHomescreen) in your hack to
> reduce anything.

Dear Alive,

Where could I check it to let the incoming app not to redraw ? 

Thanks.
Flags: needinfo?(alive)
(In reply to ben.song from comment #8)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7)
> > It is just the side effect that you did not let the incoming app to redraw
> > before seeing it. So please check if (this.isHomescreen) in your hack to
> > reduce anything.
> 
> Dear Alive,
> 
> Where could I check it to let the incoming app not to redraw ? 
> 
> Thanks.

It's hard to explain and I don't have your change so.

So, removing Transition is fine, and reduce the timeout is also fine, but that means, you DID NOT let the homescreen to have enough time to redraw. That is why you see reflow when back to homescreen. So what I am proposed is NOT have the 100ms BUT keep the 500ms ONLY for HomescreenWindow - that is to say please use this.isHomescreen to check before you reduce the timeout.
Flags: needinfo?(alive)
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #9)
> (In reply to ben.song from comment #8)
> > (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7)
> > > It is just the side effect that you did not let the incoming app to redraw
> > > before seeing it. So please check if (this.isHomescreen) in your hack to
> > > reduce anything.
> > 
> > Dear Alive,
> > 
> > Where could I check it to let the incoming app not to redraw ? 
> > 
> > Thanks.
> 
> It's hard to explain and I don't have your change so.
> 
> So, removing Transition is fine, and reduce the timeout is also fine, but
> that means, you DID NOT let the homescreen to have enough time to redraw.
> That is why you see reflow when back to homescreen. So what I am proposed is
> NOT have the 100ms BUT keep the 500ms ONLY for HomescreenWindow - that is to
> say please use this.isHomescreen to check before you reduce the timeout.

Dear Alive,

OK, thanks, we would do like this, but it would enlarge the time of backing to homescreen and sprd QA would reject this effect.

Thanks.
Blocks: 1123554
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.