Closed Bug 1118639 Opened 10 years ago Closed 10 years ago

Write before and after tests for sidebars to check that no sidebars are showing

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1815
46 bytes, text/x-github-pull-request
jsantell
: review+
Details | Review
No description provided.
With the before & after tests introduced recently (see bug 892126) I'd like to see before and after tests for the sidebar, this bug is for creating before and after tests that there are no sidebars showing.
Assignee: nobody → evold
Blocks: sdk/ui/sidebar
Depends on: 1118921
Attachment #8545420 - Flags: review?(jsantell)
Comment on attachment 8545420 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1815 r+ once squashed down
Attachment #8545420 - Flags: review?(jsantell) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/841e450929e1a2284d726783e8d3939ab3450959 Bug 1118639 - Write before and after tests for sidebars to check that no sidebars are showing https://github.com/mozilla/addon-sdk/commit/45afbd92ff1c663a985deb6c4ef46fb68a963182 Merge pull request #1818 from erikvold/1118639v2 Bug 1118639 - Write before and after tests for test-ui-sidebars.js r=jsantell
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: