1118656 - [Spam] In Revision Dashboard, add a mark next to blocked users

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Jean-Yves Perrier [:teoli]]

Feature changed: The revision dashboard: https://developer.mozilla.org/en-US/dashboards/revisions?locale=&user=&topic=&start_date=&end_date=&page=1

Problem solved:
When dealing with spammers, we now see quickly if a page has been deleted.

But to know if somebody has banned a user, we need to rely on:
1. An e-mail sent to the spam watcher list.
2. A visit to the users/userban admin panel.

Who would use this:
Any person watching spam.

What users would see:
On the Revision dashboard, a small red mention ("Banned") would appear next to the username of a banned user.

What would users do:
Spam fighters will know the banning status of a spammer at the very same place they go to check their activities.

(This is especially useful for spam that is not detected by the automatic e-mails)

Comment 1

[Jean-Yves Perrier [:teoli]]

Attachment: How this feature could look like

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

:groovecoder, can you estimate the level of effort needed to implement this?

Comment 3

[Luke Crouch [:groovecoder]]

LOE 2 just because we should move the "Is this user banned?" logic up into the model layer (it's currently in the view layer [1]) when we do this.

Good mentored bug for devs who know django.

[1] https://github.com/mozilla/kuma/blob/master/kuma/users/views.py#L85

Comment 4

[Luke Crouch [:groovecoder]]

Should also add the same visual indicator to the profile page for site admins.

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

PR here: https://github.com/mozilla/kuma/pull/2991

Comment 6

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/825336004e1e5341355147b3f6064f27f0a1a011
[fix bug 1118656] Flag spammers in UI

https://github.com/mozilla/kuma/commit/d15d2d902c15f572db32b50039d5c1bbe92e6fd9
[fix bug 1118656] move banned flag into inactive button

https://github.com/mozilla/kuma/commit/104e0e99e55cdcae7fd6edc662051da8251f6afd
[fix bug 1118656] Flag spammers in UI

Did the todo in hootseeno's comments, added link to active ban.

https://github.com/mozilla/kuma/commit/47699e8397819d706d7a039e593713c53d48fdfb
Merge pull request #3004 from stephaniehobson/hoosteeno-bug1118656

[fix bug 1118656] Flag spammers in UI