1118724 - Private comments on public bugs are sent unencrypted by email

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Nicolas B. Pierron [:nbp] {away}]

I made a Private comment in Bug 1118469 comment 3, this comment was sent back to me in a plain text (html) email.

I would expect such emails to be ciphered before being sent to anybody, as it is done for security sensitive issues.

Comment 1

[David Lawrence [:dkl]]

Email notifications are only encrypted if the bug they are for are marked as private to a security sensitive group. Bug 1118469 is not marked private to any of those groups. Private comments are just filtered out of emails and the UI for people not in the 'insidergroup' and are not normally encrypted.

dkl

Comment 2

[Nicolas B. Pierron [:nbp] {away}]

(In reply to David Lawrence [:dkl] from comment #1)
> Email notifications are only encrypted if the bug they are for are marked as
> private to a security sensitive group. Bug 1118469 is not marked private to
> any of those groups. Private comments are just filtered out of emails and
> the UI for people not in the 'insidergroup' and are not normally encrypted.

So the "Private" flag is not even making any private email, and anybody who is rooting such email can see the content which was supposed to be "Private", right?

Comment 3

[David Lawrence [:dkl]]

(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> (In reply to David Lawrence [:dkl] from comment #1)
> > Email notifications are only encrypted if the bug they are for are marked as
> > private to a security sensitive group. Bug 1118469 is not marked private to
> > any of those groups. Private comments are just filtered out of emails and
> > the UI for people not in the 'insidergroup' and are not normally encrypted.
> 
> So the "Private" flag is not even making any private email, and anybody who
> is rooting such email can see the content which was supposed to be
> "Private", right?

Private in the context of comments just means that the comment will be filtered out and not visible to everyone except privileged accounts. It does not mean private in the it makes the email encrypted to those who can see the comment. Marking a bug as private to a group that has encryption enable will only do that.

dkl

Comment 4

[Daniel Veditz [:dveditz]]

Reopening because I agree with Nicolas this is not what we expect to happen. Private comments are only available to core-security (insidergroup) people and bugs filed in that group are sent encrypted. One common use for such comments is to note that a particular bug has security implications when we don't want to hide the entire bug because the general issue is already public. Why wouldn't that comment need the same protection we would give had we hidden the entire bug?

I guess this isn't a "bug" if securemail wasn't designed that way, but it's at least a perfectly valid feature request.

Comment 5

[David Lawrence [:dkl]]

(In reply to Daniel Veditz [:dveditz] from comment #4)
> Reopening because I agree with Nicolas this is not what we expect to happen.
> Private comments are only available to core-security (insidergroup) people
> and bugs filed in that group are sent encrypted. One common use for such
> comments is to note that a particular bug has security implications when we
> don't want to hide the entire bug because the general issue is already
> public. Why wouldn't that comment need the same protection we would give had
> we hidden the entire bug?
> 
> I guess this isn't a "bug" if securemail wasn't designed that way, but it's
> at least a perfectly valid feature request.

Ok. After reading the code more closely, I realize now that the body of the email containing the private comments (if not filtered out) should be encrypted. I initially did not put it together that the insidergroup was set to core-security which is indeed a SecureMail enabled group.

I will investigate this further. Nicolas, do you still have the email and can you attach it making sure to include the headers. Remove the private comment which I don't need anyway.

Thanks
dkl

Comment 6

[Nicolas B. Pierron [:nbp] {away}]

Attachment: email

Comment 7

[David Lawrence [:dkl]]

Attachment: 1118724_1.patch

Ok found this issue. It was an issue with not properly taking multi-part emails into account when looking for a private comment in the text. Putting fix up for review.

dkl

Comment 8

[:glob ✱]

Comment on attachment 8546123 [details] [diff] [review]
1118724_1.patch

Review of attachment 8546123 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 9

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0b5e63f..2bf5ed2  master -> master

Comment 10

[David Lawrence [:dkl]]

This is live now.