1118728 - Update Phone app object to wait for the app to launch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

Some tests are failing because the Phone app takes a little longer to launch.


Update the app object to wait for the app to launch

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27197

Comment 2

[Florin Strugariu [:Bebe]]

The tests that's failing is test_redial_last_number
http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.ui.functional.non-smoke.1/91/HTML_Report/

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8545232 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27197

Looks good to me. I started http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/551 to make sure of the fix on the redial test.

Comment 4

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #3)
> http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/551

Typo in the build parameters: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/552/

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 8545232 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27197

I started another adhoc, as the previous one failed(device not found): http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/555/console
Adhoc looks good, r+

Comment 6

[Viorela Ioia [:viorela]]

(In reply to Viorela Ioia [:viorela] from comment #5)
> Comment on attachment 8545232 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27197
> 
> I started another adhoc, as the previous one failed(device not found):
> http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/555/console
> Adhoc looks good, r+

Adhoc looks good, 2 failures unrelated :)

Comment 7

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/ee0f820bc9820e45fe5d7a4ce75f081d4ec83239