1118732 - Improve performance of typing using the on-screen keyboard

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I don't know if the keyboard app object's send method has every been profiled. It's certainly slow and I'm sure there's some simple optimisations we could implement.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27198

This showed a considerable improvement. For a typical URL it was over 30% faster. I think there might be some more room for improvement, but now I think most of the time is spent on the communication with the Marionette server.

Comment 2

[Florin Strugariu [:Bebe]]

LGTM 

I also restarted some Desktop job to check the stability:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=adfd32219b33

The Device run looks OK:
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/553/console

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I thought it would be interesting to compare the test durations without this patch, so kicked off another adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/560/console

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Without patch:
test_keyboard_basic took 113452ms
test_number_keyboard took 64458ms
test_keyboard_predictive_key took 91979ms
test_basic_email_keyboard took 82045ms
test_keyboard_bug_1073870 took 75443ms

With patch:
test_keyboard_basic took 102383ms
test_number_keyboard took 66494ms
test_keyboard_predictive_key took 86081ms
test_basic_email_keyboard took 77229ms
test_keyboard_bug_1073870 took 75114ms

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/3446a7b7aca75769981c1da7158895e85e7b6583

Comment 6

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Awesome, thanks for this!