Closed Bug 1118732 Opened 7 years ago Closed 7 years ago

Improve performance of typing using the on-screen keyboard

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: davehunt, Assigned: davehunt)

Details

Attachments

(1 file)

I don't know if the keyboard app object's send method has every been profiled. It's certainly slow and I'm sure there's some simple optimisations we could implement.
This showed a considerable improvement. For a typical URL it was over 30% faster. I think there might be some more room for improvement, but now I think most of the time is spent on the communication with the Marionette server.
Attachment #8545239 - Flags: review?(florin.strugariu)
Attachment #8545239 - Flags: review?(florin.strugariu) → review+
I thought it would be interesting to compare the test durations without this patch, so kicked off another adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/560/console
Flags: needinfo?(dave.hunt)
Without patch:
test_keyboard_basic took 113452ms
test_number_keyboard took 64458ms
test_keyboard_predictive_key took 91979ms
test_basic_email_keyboard took 82045ms
test_keyboard_bug_1073870 took 75443ms

With patch:
test_keyboard_basic took 102383ms
test_number_keyboard took 66494ms
test_keyboard_predictive_key took 86081ms
test_basic_email_keyboard took 77229ms
test_keyboard_bug_1073870 took 75114ms
Flags: needinfo?(dave.hunt)
Landed in:
https://github.com/mozilla-b2g/gaia/commit/3446a7b7aca75769981c1da7158895e85e7b6583
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.