Closed Bug 1118732 Opened 7 years ago Closed 7 years ago
Improve performance of typing using the on-screen keyboard
46 bytes, text/x-github-pull-request
|Details | Review|
I don't know if the keyboard app object's send method has every been profiled. It's certainly slow and I'm sure there's some simple optimisations we could implement.
This showed a considerable improvement. For a typical URL it was over 30% faster. I think there might be some more room for improvement, but now I think most of the time is spent on the communication with the Marionette server.
Attachment #8545239 - Flags: review?(florin.strugariu)
LGTM I also restarted some Desktop job to check the stability: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=adfd32219b33 The Device run looks OK: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/553/console
Attachment #8545239 - Flags: review?(florin.strugariu) → review+
I thought it would be interesting to compare the test durations without this patch, so kicked off another adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/560/console
Without patch: test_keyboard_basic took 113452ms test_number_keyboard took 64458ms test_keyboard_predictive_key took 91979ms test_basic_email_keyboard took 82045ms test_keyboard_bug_1073870 took 75443ms With patch: test_keyboard_basic took 102383ms test_number_keyboard took 66494ms test_keyboard_predictive_key took 86081ms test_basic_email_keyboard took 77229ms test_keyboard_bug_1073870 took 75114ms
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Awesome, thanks for this!
You need to log in before you can comment on or make changes to this bug.