Closed Bug 1118738 Opened 8 years ago Closed 8 years ago

HTML report missing colours for expected skips and unexpected errors

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: davehunt, Assigned: davehunt)

Details

Attachments

(1 file)

Fix HTML report colours for expected skips and unexpected errors. v1.0
1.21 KB, patch
jgraham
: review+
Details | Diff | Splinter Review 
The test results for EXPECTED_SKIP and UNEXPECTED_ERROR do not have the correct styles applied in the HTML report.
Comment on attachment 8545246 [details] [diff] [review]
Fix HTML report colours for expected skips and unexpected errors. v1.0

Review of attachment 8545246 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Possibly still missing some rules for other states e.g. [unexpected_]crash?
Attachment #8545246 - Flags: review?(james) → review+
Thanks. I think we'd want to add a summary count for crashes too, so bumping this to a separate issue.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cb37bece36f3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.