1118747 - Autophone - S1S2 -Throbber stop regression on 2015-01-05

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

Autophone Throbber stop regressed on 2015-01-05. start appears unaffected. Most noticable on Nexus S.

http://phonedash.mozilla.org/#/org.mozilla.fennec/throbberstop/local-blank/norejected/2015-01-05/2015-01-05/notcached/noerrorbars/standarderror

https://treeherder.allizom.org/ui/#/jobs?repo=mozilla-inbound&fromchange=69c16464fa30&tochange=1a932cff0528

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=69c16464fa30&tochange=1a932cff0528

regressed by Bug 1110271 - Enable openh264 via GMP on Android

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: openh264-better-delay v0.1

When Firefox tries to do work during startup, this is what happens. Sadly, it seems we are limited by how we can install the OpenH264 add-on code, so let's try to match Desktop here. This patch:
1. Moves the install check into the dispatch queue
2. Waits one minute before calling the init (like Desktop)

See http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1351

Comment 2

[:Margaret Leibovic]

Comment on attachment 8545913 [details] [diff] [review]
openh264-better-delay v0.1

Review of attachment 8545913 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +376,5 @@
> +          // Delay this a minute because there's no rush
> +          setTimeout(() => {
> +            BrowserApp.gmpInstallManager = new GMPInstallManager();
> +            BrowserApp.gmpInstallManager.simpleCheckAndInstall().then(null, () => {});
> +          }, 1000 * 60);

I'm not familiar with this GMPInstallManager business. How certain do we want to be that we call this code? Unlike desktop, Fennec doesn't always run for a whole minute before getting killed. If we go with this approach, we need to be okay with that.

Maybe we should use a pref to keep track of how many times we've punted on this check, and if we still haven't done it after something like 10 app runs, we should just do it sooner.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/8e516e029c8e

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #2)
> Comment on attachment 8545913 [details] [diff] [review]
> openh264-better-delay v0.1
> 
> Review of attachment 8545913 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/chrome/content/browser.js
> @@ +376,5 @@
> > +          // Delay this a minute because there's no rush
> > +          setTimeout(() => {
> > +            BrowserApp.gmpInstallManager = new GMPInstallManager();
> > +            BrowserApp.gmpInstallManager.simpleCheckAndInstall().then(null, () => {});
> > +          }, 1000 * 60);
> 
> I'm not familiar with this GMPInstallManager business. How certain do we
> want to be that we call this code? Unlike desktop, Fennec doesn't always run
> for a whole minute before getting killed. If we go with this approach, we
> need to be okay with that.

I think we are OK for now. That could change though, as this feature starts being used more often.

> Maybe we should use a pref to keep track of how many times we've punted on
> this check, and if we still haven't done it after something like 10 app
> runs, we should just do it sooner.

We were talking about ways around this issue on IRC. I'd like to remove it entirely from browser.js and put it into a background service. This is essentially and specific downloader for video plugins. If we need to add some complexity, I'd rather spend it by removing it completely from our startup path.

Comment 5

[Bob Clary [:bc] (inactive)]

Looks like comment 3 definitely helped with nexus s on fx-team:

http://phonedash.mozilla.org/#/org.mozilla.fennec/throbberstop/local-twitter/norejected/2015-01-08/2015-01-08/notcached/errorbars/standarderror

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=b336e9272939&tochange=2035148cfa4d

This wasn't as dramatic a change on my local nexus one though testing before and after with custom builds...

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8e516e029c8e