1118789 - Please enable external image support (with a whitelist)

Status: RESOLVED WORKSFORME

(Websites :: wiki.mozilla.org, defect)

Description

[Justin Wood (:Callek)]

[11:19:07]	Callek	the "Show external images" thing, (e.g. if you link to an external image, it displays it rather than links it), I have a use-case for... *but* I don't expect it to be a good idea by default/for all domains. Is it possible to enable that with a whitelist? If so would you guys consider doing so
[11:19:55]	Callek	specific use case for me is: http://docs.travis-ci.com/user/status-images/
[11:20:36]	ckoehler	whitelist sounds ok to me
[11:21:08]	ckoehler	would want to double check conf options and make sure that choice doesn't have other ramifications
[11:21:45]	Callek	also wanting https://coveralls.io/r/mozilla/build-mozharness?branch=master to be supported
[11:22:08]	Callek	errr https://coveralls.io/repos/mozilla/build-mozharness/badge.png?branch=master

Found docs:

http://www.mediawiki.org/wiki/Manual:$wgAllowExternalImages
http://www.mediawiki.org/wiki/Manual:$wgEnableImageWhitelist
http://www.mediawiki.org/wiki/Manual:$wgAllowExternalImagesFrom

I'm assuming that enabling and using https://wiki.mozilla.org/MediaWiki:External_image_whitelist is going to be best for us (ideally I can also edit that page)

Comment 1

[Christie Koehler [:ckoehler]]

I've doubled-checked and external images are already permitted. 

It seems as if not all types of external images are supported, however. Specifically svg images or images generated by url query parameters. 

Here's a demo page illustrating this:
https://wiki.mozilla.org/User:Ckoehler/Demos/External_Image

More research is needed to determine if this is a bug or intentional behavior on behalf of mediawiki.

Comment 2

[Justin Wood (:Callek)]

W00t thanks!

So, using ?.png is a workaround for the case where svg is required, however it screams of a sec issue so we will avoid using it where we can.

Also the fact that [[Image:..|link=https://foobar]] doesn't show external-site link icon is either a bug or intended, but the inability for external-links this way (e.g. [https:/foobar https://some-image-url] to not have the same icon is a pain, will be filing a followup bug on it