1118827 - Crashes in mozilla::gmp::GMPChild::RecvCrashPluginNow() in GMP plugin

Status: RESOLVED WORKSFORME

(Core :: Security, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

These started with yesterday's mozilla-central nightly.  They're already the #4 Mac topcrasher.

https://crash-stats.mozilla.com/signature/?platform=Mac+OS+X&version=37.0a1&date=%3E%3D2015-01-05&signature=mozilla%3A%3Agmp%3A%3AGMPChild%3A%3ARecvCrashPluginNow%28%29&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=process_type&_columns=gmp_plugin&page=1

Chris, do you have any idea what's up?

Comment 1

[Steven Michaud [:smichaud] (Retired)]

> They're already the #4 Mac topcrasher.

On the 37 branch.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Implied regression range ... if this is indeed our bug:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=636498d041b5&tochange=2a193b7f395c

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Chris, could this have been caused/triggered by the patches for bug 1114867?

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Just looked again, and noticed that all these crashes are on OS X 10.7.5.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Steven Michaud from comment #3)
> Chris, could this have been caused/triggered by the patches for bug 1114867?

No. The code in bug 1114867 only runs on Windows.

I don't know why this would spike on Windows.

Jesup, and ideas?

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Oddly, there still aren't any of these for m-c nightlies later than firefox-2015-01-06-03-02-01.  Maybe this was just some kind of fluke.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

As best I can tell, these crashes were all submitted by the same person (on the same machine).  All reports have the same "install time" and the same list of extensions ([e-mail] 2.0.9 and [e-mail] 3.0.3).

Henrik, was this you? :-)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, but there are tests running manual and soon automatically with Mozmill for checking the GMP crash behavior. AFAIR Cosmin is working on it, so CC'ing him. I actually cannot find the appropriate bug. When querying Bugzilla I only see bug 1046052, but that's not Mozmill tests.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, found it. It's bug 1113087 and it is indeed Cosmin who is working on it.

Comment 10

[Steven Michaud [:smichaud] (Retired)]

I just figured out this bug is probably nothing to worry about.  In fact these crashes probably resulted from setting media.gmp.plugin.crash to true in about:config :-)

So I'll set this bug WFM.  Please re-open if I'm wrong, and this is a real bug.

Comment 11

[Cosmin Malutan, [:cosmin-malutan]]

Yes, this is from running the moztrap https://moztrap.mozilla.org/manage/case/14441/ and setting the  media.gmp.plugin.crash preference to true.

Comment 12

[Steven Michaud [:smichaud] (Retired)]

Thanks, Cosmin, for letting me know.