1118987 - create a new bug form for discourse issues (based on form.reps.it)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Custom Bug Entry Forms, defect)

Description

[Tanner Filip [:tanner]]

It shouldn't be in the reps form, and it should be put in this category. Tad helped us with the last one, so he should be able to do this one.

Comment 1

[tad]

moving to bugzilla :)

bugzillians,

Can we remove the Discourse category from https://bugzilla.mozilla.org/form.reps.it please?

Let's create a new form, form.csa.discourse. Use the information from reps.it as a template, the base questions (name, community, mozillians profile, reps profile) and the questions from the discourse category option

Send the bugs to Infra and Ops > Community IT :: Discourse

Would be great!!!! thanks c:

Comment 2

[Leo McArdle [:leo]]

Take out reps profile - there's no reason to limit requests for categories to reps only.

Comment 3

[tad]

leo,

it's not about limiting to reps

It's about gathering profile data to easily find people. Reps is an optional field.

Comment 4

[Tanner Filip [:tanner]]

We don't have a use for the reps field. The module owner and peers of Discourse have discussed it. It could give the impression that only reps are welcome to request categories, and this is obviously not true.

Comment 5

[tad]

The form does make it explicit that it's only "if applicable" but not my call.

anything goes for me. leaving this bug for now, not sure why I was assigned to this in the first place.

Comment 6

[David Lawrence [:dkl]]

I have pushed my changes to our testing system for your feedback here:

https://bugzilla-dev.allizom.org/form.csa.discourse

Let me know if the form looks correct. Also I have removed the Discourse option from the form.reps.it form if you want to verify that as well.

https://bugzilla-dev.allizom.org/form.reps.it

Thanks
dkl

Comment 7

[Tanner Filip [:tanner]]

From the Discourse form, can you please remove the moderators and reps profile? Sorry, I wasn't intending this bug to be put in the Bugzilla component, which is why I filed it under Community IT without much detail.

Thanks!

Comment 8

[Dylan Hardison [:dylan] (he/him)]

We'll have the next revision up for demo on bugzilla-dev as soon as we finish some branch cleanup. Sorry for the wait!

Comment 9

[Dylan Hardison [:dylan] (he/him)]

I have removed moderators and the reps profile from the CSA Discourse form. The changes are available for review below:

https://bugzilla-dev.allizom.org/form.csa.discourse

Comment 10

[Tanner Filip [:tanner]]

Looks good to me, thanks much!

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1118987-v2.patch

And here is this for review.

Comment 12

[:glob ✱]

Comment on attachment 8565504 [details] [diff] [review]
bug-1118987-v2.patch

Review of attachment 8565504 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with issues to be fixed on commit.

::: extensions/REMO/template/en/default/bug/create/create-remo-it.html.tmpl
@@ -251,5 @@
> -<tr class="odd">
> -  <th>Hex code of background of category tag:</th>
> -  <td><input id="discourse_bg" name="discourse_bg" size="40"></td>
> -</tr>
> -</tbody>

the discourse fields have been removed from the form, but not from the comment template.

::: extensions/REMO/web/js/moz_csa_discourse.js
@@ +3,5 @@
> + * You can obtain one at http://mozilla.org/MPL/2.0/.
> + *
> + * This Source Code Form is "Incompatible With Secondary Licenses", as
> + * defined by the Mozilla Public License, v. 2.0. */
> +/*global $ */

as per our discussion, this belongs in a project-wide file, not in each individual file.

@@ +32,5 @@
> +            errors.push("There are missing required fields");
> +        }
> +
> +        if (errors.length) {
> +            alert(errors.join("\n"));

this should event.preventDefault(); and return

Comment 13

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   c8c9ad0..ac997a9  master -> master