1119012 - "No logs available for this job" visible if there was an error summary but no log links

Status: NEW

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Attachment: Screenshot

See screenshot

Comment 1

[Ed Morley [:emorley]]

jfrench, I think this was fixed by one of your changes recently, right? :-)

Comment 2

[Jonathan French (:jfrench)]

Hm, I don't think I have touched this recently other than a tiny css fix to remove that funny little bit of blue padding in front of the "No logs available.." message
https://github.com/mozilla/treeherder-ui/pull/439

Looking at master, the markup and controller were last touched 3 months ago
https://github.com/mozilla/treeherder-ui/tree/master/webapp/app/plugins/failure_summary

I gather job_log_urls.length is somehow returning false in that job
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/failure_summary/main.html#L79

Comment 3

[Ed Morley [:emorley]]

So this occurs if:
1) There were no log urls
2) There was a "Bug suggestions" artifact returned, and if that artifact contains just one error line, and no bug suggestion.

This case originally occurred, due to bug 1142559. It's since been fixed - however given bug 1080760 - I can imagine in the future we might (accidentally or otherwise) have cases where we don't have a log URL for a job, but we were given an error summary.

As such, we should probably change the conditional here:
https://github.com/mozilla/treeherder/blob/9da6ddbf4151436f20a763d9543b86409214d8c3/ui/plugins/failure_summary/main.html#L89

So that it also includes something like:
bugSuggestionsLoaded && suggestions.length == 0