1119031 - [RTL][System] "System update" dialog header is left-aligned.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: SystemUpdate.jpg

Description:
During OTA upgrade, the string "System update" is left-aligned.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150106010234
2) Connect to a Wi-Fi network.
3) When the update notification appears, select the notification.
4) Select "Download" to download the system update.
5) When the downloading and uncompressing are complete, select "Install Now".
6) Observe the "System update" dialog.
  
Actual:
The header is left-aligned.
  
Expected: 
The header is right-aligned.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150106010234
Gaia: b77e0d56d197e0ee02d801a25c784130d888c9db
Gecko: 2a193b7f395c
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: picture

Comment 1

[Gregor Wagner [:gwagner]]

Chris, can you take a look?

Comment 2

[bhavana bajaj [:bajaj]]

We will uplift if we have a fix for this in FxOS 2.2

Comment 3

[Chris Lord [:cwiiis]]

Ahmed, I don't suppose you have time to have a look at this? (pass the n? back to me if you don't :))

Comment 4

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 5

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 6

[Gregor Wagner [:gwagner]]

Can we just center the text?

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

As per UX specs (p.7 for example), this should be right-aligned - not centered. Thanks!

Comment 8

[Chris Lord [:cwiiis]]

I'll take this.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Stealing.

Comment 10

[GitHub Autolander Bot]

Attachment: [PullReq] mikehenrty:bug-1119031-rtl-system-update to mozilla-b2g:master

Comment 11

[Chris Lord [:cwiiis]]

Comment on attachment 8562010 [details] [review]
[PullReq] mikehenrty:bug-1119031-rtl-system-update to mozilla-b2g:master

If my review will do, here's an r+ - thanks for stealing :)

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8562010 [details] [review]
[PullReq] mikehenrty:bug-1119031-rtl-system-update to mozilla-b2g:master

(In reply to Chris Lord [:cwiiis] from comment #11)
> Comment on attachment 8562010 [details] [review]
> [PullReq] mikehenrty:bug-1119031-rtl-system-update to mozilla-b2g:master
> 
> If my review will do, here's an r+ - thanks for stealing :)

I haven't looked/tested the code yet, but I'll just R+ stamp it with your review so there's technically a peer on this. Thanks Chris!

Comment 13

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3f29997813ea5ed7fd37fa7efea25a114092cc10

Comment 14

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 3.0

With language set to Arabic, OTA from 20150210160206 to 20150211010216 shows System Update header on splash screen as right-aligned after pressing "Install now".

Adding verifyme keyword awaiting 2.2 uplift

Device: Flame 3.0 Master
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0