1119050 - [manifest] allow relative launch paths like './index.html'

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Now that we no longer require hosted apps to have a unique domain, we should consider allowing apps to leverage a relative launch_path. This is helpful, for instance, if an organization wants to host multiple hosted apps on github pages. Since github pages all use the same domain, you could host the manifest URLS at

my-org.github.io/app-1-repo/manifest.webapp
my-org.github.io/app-2-repo/manifest.webapp

And have the launch paths be './index.html'. Right now, launch paths are required by the validator [1] to start with '/', which obviously breaks the github workflow for multiple apps.

To be clear, this is a validation bug only. The mozApps.install API works just fine with a relative launch path. You just can't submit that app to market yet.

1.) https://github.com/mozilla/app-validator/blob/4d1670b7c3fdccda56d716ad5fc577b0535d3732/appvalidator/specs/webapps.py#L351

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

There are similar issues for other URLs, like icons[1].  Should these be relaxed too?

[1]: https://github.com/mozilla/app-validator/blob/4d1670b7c3fdccda56d716ad5fc577b0535d3732/appvalidator/specs/webapps.py#L375

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> There are similar issues for other URLs, like icons[1].  Should these be
> relaxed too?
> 
> [1]:
> https://github.com/mozilla/app-validator/blob/
> 4d1670b7c3fdccda56d716ad5fc577b0535d3732/appvalidator/specs/webapps.py#L375

I don't see why not. But we would need to verify that relative paths work for icons as well.

Comment 3

[Andrew Williamson [:eviljeff]]

I worry about breakage on older versions of FxOS.  Our base platform is still FxOS1.1 and we will reject apps that don't work on it.  I'm tempted to say this depends on bug 1108570 really.