1119061 - Add telemetry for Android Sync migration process

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

At first blush, perhaps:

* number of syncs against Old Sync account;
* number of GET requests against meta/fxa_credentials;
* number of meta/fxa_credentials fetched;
* number of migrations failed/succeeded;
* number of times "Finish migrating?" notification displayed, or (even better) duration of time that we spend in "MigratedFromSync11" state.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/522

I have manually verified that the TelemetryWrapper works when run from within Fennec, but I have not:

1) verified that the wrapper works when Fennec (Gecko) is not running;
2) verified that the telemetry is actually stored or uploaded.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8549298 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/522

Looks good. Eagerly awaiting the part 2 that adds the histograms.

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1119061/nalexander

Comment 4

[Nick Alexander :nalexander [he/him]]

/r/2573 - Bug 1119061 - Part 1: Add Fennec-specific Sync 1.1 -> Sync 1.5 migration telemetry histograms. r=rnewman

Pull down this commit:

hg pull review -r 74fd7f2594714f039a2d8b457775f6b393ec5cf4

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/94d2782392e4
https://hg.mozilla.org/integration/fx-team/rev/72103138c055

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/94d2782392e4
https://hg.mozilla.org/mozilla-central/rev/72103138c055

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8549909 [details]
MozReview Request: bz://1119061/nalexander

This landed with rnewman's review.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8549909 [details]
MozReview Request: bz://1119061/nalexander

Approval Request Comment
[Feature/regressing bug #]: feature.  We expect to start migrating Sync users in Firefox 37.  This should be there to collect migration uptake data on pre-release channels.

[User impact if declined]: we'll be flying blind: we won't get any data on the success/fail rate of Android Sync migration uptake.

[Describe test coverage new/current, TreeHerder]: manually tested.

[Risks and why]: very low.  This is new code that is only triggered during Sync migrations.  If we saw crashes, we'd get clean stacktraces for them.

[String/UUID change made/needed]: none.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8549909 [details]
MozReview Request: bz://1119061/nalexander

Aurora+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7b01079e4265
https://hg.mozilla.org/releases/mozilla-aurora/rev/e5eab843738c

Comment 12

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1119061 - Part 1: Add Fennec-specific Sync 1.1 -> Sync 1.5 migration telemetry histograms. r=rnewman