57 bytes, text/x-github-pull-request
|Details | Review|
MozReview Request: Bug 1119061 - Part 1: Add Fennec-specific Sync 1.1 -> Sync 1.5 migration telemetry histograms. r=rnewman
39 bytes, text/x-review-board-request
At first blush, perhaps: * number of syncs against Old Sync account; * number of GET requests against meta/fxa_credentials; * number of meta/fxa_credentials fetched; * number of migrations failed/succeeded; * number of times "Finish migrating?" notification displayed, or (even better) duration of time that we spend in "MigratedFromSync11" state.
I have manually verified that the TelemetryWrapper works when run from within Fennec, but I have not: 1) verified that the wrapper works when Fennec (Gecko) is not running; 2) verified that the telemetry is actually stored or uploaded.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8549298 - Flags: review?(rnewman)
Component: Firefox Sync: Cross-client → Android Sync
Product: Mozilla Services → Android Background Services
Comment on attachment 8549298 [details] [review] Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/522 Looks good. Eagerly awaiting the part 2 that adds the histograms.
Attachment #8549298 - Flags: review?(rnewman) → review+
/r/2573 - Bug 1119061 - Part 1: Add Fennec-specific Sync 1.1 -> Sync 1.5 migration telemetry histograms. r=rnewman Pull down this commit: hg pull review -r 74fd7f2594714f039a2d8b457775f6b393ec5cf4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Comment on attachment 8549909 [details] MozReview Request: bz://1119061/nalexander This landed with rnewman's review.
Attachment #8549909 - Flags: review?(rnewman) → review+
Comment on attachment 8549909 [details] MozReview Request: bz://1119061/nalexander Approval Request Comment [Feature/regressing bug #]: feature. We expect to start migrating Sync users in Firefox 37. This should be there to collect migration uptake data on pre-release channels. [User impact if declined]: we'll be flying blind: we won't get any data on the success/fail rate of Android Sync migration uptake. [Describe test coverage new/current, TreeHerder]: manually tested. [Risks and why]: very low. This is new code that is only triggered during Sync migrations. If we saw crashes, we'd get clean stacktraces for them. [String/UUID change made/needed]: none.
Attachment #8549909 - Flags: approval-mozilla-aurora?
Comment on attachment 8549909 [details] MozReview Request: bz://1119061/nalexander Aurora+
Attachment #8549909 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.