Closed Bug 1119065 Opened 10 years ago Closed 6 years ago

Properly handle failures due to lack of editbugs privilege

Categories

(MozReview Graveyard :: General, defect, P3)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: gps, Unassigned)

References

Details

If a Bugzilla user isn't in the editbugs group, they can't edit attachments. Unfortunately, I don't think we handle this properly. As part of hacking on the test environment, I inadvertently removed editbugs from all users and got a number of test failures and unexpected errors in the RB log. I suspect the web interface is also not happy, but I didn't verify. We should have better UX around editbugs lackings. We should probably hide or gray out the "review" UI if the user doesn't have those permissions. See also bug 993218.
We need to investigate editbugs in general, since with GitHub imports, new contributors won't have editbugs, but they'll need to be able to (indirectly) add attachments and such.
Assignee: nobody → mcote
Priority: -- → P1
Product: Developer Services → MozReview
Assignee: mcote → nobody
Priority: P1 → P3
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.