1119066 - Tiling on Windows w/ Direct2D does not invalidate correctly

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: Capture.PNG

With Direct2D and tiling enabled, lots of tiles no longer paint correctly. Attached screenshot shows what it looks like (note paint flashing is on here). bisect points to bug 1088414.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1119066.patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8546094 [details] [diff] [review]
bug1119066.patch

Review of attachment 8546094 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +1068,4 @@
>    }
>    if (aTile.mFrontBufferOnWhite && aTile.mFrontBufferOnWhite->IsLocked()) {
>      aTile.mFrontBufferOnWhite->Unlock();
> +    aTile.mFrontBufferOnWhite->SyncWithObject(mCompositableClient->GetForwarder()->GetSyncObject());

We should only need to sync TextureClients that we modified, which won't be these two front buffers.

Do we even need the back buffer syncs here? Seems like the one in ValidateTile should be all we need.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1119066.patch

Yup you're right, just that seems to work.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6713687c18b3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6713687c18b3