Closed Bug 1119066 Opened 6 years ago Closed 6 years ago

Tiling on Windows w/ Direct2D does not invalidate correctly

Categories

(Core :: Graphics, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image Capture.PNG
With Direct2D and tiling enabled, lots of tiles no longer paint correctly. Attached screenshot shows what it looks like (note paint flashing is on here). bisect points to bug 1088414.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Attached patch bug1119066.patch (obsolete) — Splinter Review
Attachment #8546094 - Flags: review?(matt.woodrow)
Comment on attachment 8546094 [details] [diff] [review]
bug1119066.patch

Review of attachment 8546094 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +1068,4 @@
>    }
>    if (aTile.mFrontBufferOnWhite && aTile.mFrontBufferOnWhite->IsLocked()) {
>      aTile.mFrontBufferOnWhite->Unlock();
> +    aTile.mFrontBufferOnWhite->SyncWithObject(mCompositableClient->GetForwarder()->GetSyncObject());

We should only need to sync TextureClients that we modified, which won't be these two front buffers.

Do we even need the back buffer syncs here? Seems like the one in ValidateTile should be all we need.
Attached patch bug1119066.patchSplinter Review
Yup you're right, just that seems to work.
Attachment #8546094 - Attachment is obsolete: true
Attachment #8546094 - Flags: review?(matt.woodrow)
Attachment #8546497 - Flags: review?(matt.woodrow)
Attachment #8546497 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/6713687c18b3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.