Tiling on Windows w/ Direct2D does not invalidate correctly

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

unspecified
mozilla37
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Posted image Capture.PNG
With Direct2D and tiling enabled, lots of tiles no longer paint correctly. Attached screenshot shows what it looks like (note paint flashing is on here). bisect points to bug 1088414.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Posted patch bug1119066.patch (obsolete) — Splinter Review
Attachment #8546094 - Flags: review?(matt.woodrow)
Comment on attachment 8546094 [details] [diff] [review]
bug1119066.patch

Review of attachment 8546094 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +1068,4 @@
>    }
>    if (aTile.mFrontBufferOnWhite && aTile.mFrontBufferOnWhite->IsLocked()) {
>      aTile.mFrontBufferOnWhite->Unlock();
> +    aTile.mFrontBufferOnWhite->SyncWithObject(mCompositableClient->GetForwarder()->GetSyncObject());

We should only need to sync TextureClients that we modified, which won't be these two front buffers.

Do we even need the back buffer syncs here? Seems like the one in ValidateTile should be all we need.
Yup you're right, just that seems to work.
Attachment #8546094 - Attachment is obsolete: true
Attachment #8546094 - Flags: review?(matt.woodrow)
Attachment #8546497 - Flags: review?(matt.woodrow)
Attachment #8546497 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/6713687c18b3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.