1119070 - Add query parameter saying we're migrating to Android Sync to after-migration /account/login HTTP request

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is the Android client implementation of Bug 1119027.  Part of this ticket is agreeing on the query parameter.

Comment 1

[Nick Alexander :nalexander [he/him]]

Test plan: manual test transcript from the |adb logcat|:

Create a new account.  Verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/create?service=sync&keys=true

Drive account into disconnected state.  Update credentials and verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/login?service=sync&keys=true

Drive account into migrated state.  Update credentials and verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/login?service=sync&keys=true&migration=sync11

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/520

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/c8634e2a4117

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c8634e2a4117

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8547819 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/520

Approval Request Comment
[Feature/regressing bug #]: feature.  We expect to start migrating Sync users in Firefox 37.  This should be there to provide the accounts backend with migration data.

[User impact if declined]: we won't provide the Cloud Services metrics team with data on the success/fail rate of Android Sync migration.

[Describe test coverage new/current, TreeHerder]: manually tested.

[Risks and why]: very low.  This is new code that is only triggered during Sync migrations.  If we saw crashes, we'd get clean stacktraces for them.

[String/UUID change made/needed]: none.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8547819 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/520

Not the smallest changeset but a good chunk of this looks to be refactoring to collect the required data. I think it's early enough in Aurora to accept this change given the benefit of understanding sync migrations. Aurora+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cd408977f6ca