Closed Bug 1119070 Opened 6 years ago Closed 6 years ago

Add query parameter saying we're migrating to Android Sync to after-migration /account/login HTTP request

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox35 --- unaffected
firefox36 --- unaffected
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

This is the Android client implementation of Bug 1119027.  Part of this ticket is agreeing on the query parameter.
Test plan: manual test transcript from the |adb logcat|:

Create a new account.  Verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/create?service=sync&keys=true

Drive account into disconnected state.  Update credentials and verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/login?service=sync&keys=true

Drive account into migrated state.  Update credentials and verify:

D FxAccounts(10427)           fennec_nalexander :: BaseResource :: HTTP POST https://api.accounts.firefox.com/v1/account/login?service=sync&keys=true&migration=sync11
Summary: Add query parameter saying we're migrating to Android Sync after-migration /account/login HTTP request → Add query parameter saying we're migrating to Android Sync to after-migration /account/login HTTP request
Attachment #8547819 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/c8634e2a4117
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Comment on attachment 8547819 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/520

Approval Request Comment
[Feature/regressing bug #]: feature.  We expect to start migrating Sync users in Firefox 37.  This should be there to provide the accounts backend with migration data.

[User impact if declined]: we won't provide the Cloud Services metrics team with data on the success/fail rate of Android Sync migration.

[Describe test coverage new/current, TreeHerder]: manually tested.

[Risks and why]: very low.  This is new code that is only triggered during Sync migrations.  If we saw crashes, we'd get clean stacktraces for them.

[String/UUID change made/needed]: none.
Attachment #8547819 - Flags: approval-mozilla-aurora?
Comment on attachment 8547819 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/520

Not the smallest changeset but a good chunk of this looks to be refactoring to collect the required data. I think it's early enough in Aurora to accept this change given the benefit of understanding sync migrations. Aurora+
Attachment #8547819 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.