1119119 - MSE: calling appendBuffer with no data doesn't emit updateend

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

As per MSE spec:
http://w3c.github.io/media-source/#sourcebuffer-buffer-append

We're supposed to run the segment parser loop algorithm.
Which states:
http://w3c.github.io/media-source/#sourcebuffer-segment-parser-loop

1.Loop Top: If the input buffer is empty, then jump to the need more data step below.

7.Need more data: Return control to the calling algorithm.

Which upon return:
3.Set the updating attribute to false.
4.Queue a task to fire a simple event named update at this SourceBuffer object.
5.Queue a task to fire a simple event named updateend at this SourceBuffer object.

Right now we abort, and as such no update and updateend events are fired.

This is what cause errors in testing/web-platform/tests/media-source/interfaces.html (and if we apply bug 1118589 now causes timeouts as no error is immediately returned)

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Update web platform tests

Update webref test results

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Do not abort when calling appendBuffer with no data

Do not error if data appended is empty, and properly issue update/updateend event

Comment 3

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=762a6f0e0757

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Do not abort when calling appendBuffer with no data

Rebase, so it doesn't rely on async appendBuffer

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Update web-platform-tests expected data

Use ./mach web-platform-tests-update to update patch instead. Yield exactly what I had done manually with extra CR

Comment 6

[Jean-Yves Avenard [:jya]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/20a4dd540338
http://hg.mozilla.org/integration/mozilla-inbound/rev/670e66764052

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8550027 [details] [diff] [review]
Do not abort when calling appendBuffer with no data

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, possible problems with Youtube playback.
[Describe test coverage new/current, TBPL]: stable on inbound, presuming green on m-c.
[Risks and why]: MSE-specific change. Main risk is web platform test result variance from un-uplifted patches.
[String/UUID change made/needed]: None.

This request applies to all patches in this bug.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/670e66764052
https://hg.mozilla.org/mozilla-central/rev/20a4dd540338

Comment 9

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f6f59a8161e

Comment 10

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3d98b745fa61

Comment 11

[Ralph Giles (:rillian)]

This doesn't apply cleanly to beta. I'll need to do a backport before we can uplift this batch.

Comment 12

[Ralph Giles (:rillian)]

Or rather, figure out what the difference is, since this code should be the same on both branches. Looks like something with the bug 1118123 backout on 37.

Comment 13

[Jean-Yves Avenard [:jya]]

you likely would need bug 1118123 yes...
this bug is non-important, it's only required to make bug 1120084 land.

Comment 14

[Ralph Giles (:rillian)]

Ok, I traced the history. Bug 1118123 landed on firefox 37 when it was m-c, on January 9. I uplifted to 36 (then aurora) but backed it out per Jean-Yves' request. On January 12, m-c became firefox 38 and all the changed on 37 were merged into aurora. That explains why the patches from this bug apply to aurora 37, but not beta 36. I was confused because I remembered backing them out of Aurora, forgetting that was before branch uplift.

Comment 15

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4fe580b632e5
https://hg.mozilla.org/releases/mozilla-beta/rev/a1a315b3ff6b

Comment 16

[Jean-Yves Avenard [:jya]]

This has automatic coverage in the web-ref test: media-source/mediasource-append-buffer.html

this test that appendBuffer with no data properly emits update/updateend