1119137 - Complete https://developer.mozilla.org/en-US/Firefox/Australis_add-on_compat

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: Add-ons, defect)

Description

[Mathew Hodson]

There is outdated information on https://developer.mozilla.org/en-US/Firefox/Australis_add-on_compat. It still has a warning that says it is a draft and not complete at the top of the page, and there are copy and paste errors.

For example, under Icon sizes in toolbars have changed, it says, "The new icon sizes are the same on all platforms and are:The menu panel can be targetted by selecting [cui-areatype="menu-panel"]."

Comment 1

[Will Bamberg [:wbamberg]]

I've removed {{Draft}}, fixed the error mentioned and made a few other updates. Does that cover it, or are there other updates you know of, that should be added here?

Comment 2

[Mathew Hodson]

> * 18px in the navigation toolbar
> * 32px in the menu panel and palette

This part under Changes for themes should say 16px and 32px I think.

> NB: this is now fixed, except for <menulist>, which is being tracked here.

Under Known issues related to add-ons, I think the struck-through paragraph should be replaced with something like this:

If a <menulist> element is wrapped inside a toolbaritem, popping up the <menulist> closes the new menu panel. This issue is being tracked here.

> Items that are overflowed have the overflowedItem attribute set to true.

These two are just nits, but this sentence shouldn't be on its own line and should be part of the preceding paragraph.

> For toolbaritems and toolbarbuttons inserted into the add-on bar, we will
> attempt to migrate them to a visible toolbar automatically if the add-on
> bar was visible in the user's profile before migrating to Australis. However,
> depending on your add-on's code this may or may not work correctly without
> further code changes on your part.

This should be its own bullet point.

Comment 3

[:Gijs (he/him)]

(In reply to mathew.hodson from comment #2)
> > * 18px in the navigation toolbar
> > * 32px in the menu panel and palette
> 
> This part under Changes for themes should say 16px and 32px I think.

"It's complicated"...

Internal icons on the navbar use 18px. For add-ons, by default the padding is set up so it should work well if add-ons specify an icon of size 16px.

Comment 4

[Will Bamberg [:wbamberg]]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to mathew.hodson from comment #2)
> > > * 18px in the navigation toolbar
> > > * 32px in the menu panel and palette
> > 
> > This part under Changes for themes should say 16px and 32px I think.
> 
> "It's complicated"...
> 
> Internal icons on the navbar use 18px. For add-ons, by default the padding
> is set up so it should work well if add-ons specify an icon of size 16px.

Thanks Gijs. So I've made the icon size guidance the same for both extensions and themes, and included your clarification about sizes in the toolbar. Is that correct?

Mathew: thanks for your other comments, which I've addressed.

Comment 5

[:Gijs (he/him)]

(In reply to Will Bamberg [:wbamberg] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > (In reply to mathew.hodson from comment #2)
> > > > * 18px in the navigation toolbar
> > > > * 32px in the menu panel and palette
> > > 
> > > This part under Changes for themes should say 16px and 32px I think.
> > 
> > "It's complicated"...
> > 
> > Internal icons on the navbar use 18px. For add-ons, by default the padding
> > is set up so it should work well if add-ons specify an icon of size 16px.
> 
> Thanks Gijs. So I've made the icon size guidance the same for both
> extensions and themes, and included your clarification about sizes in the
> toolbar. Is that correct?
> 
> Mathew: thanks for your other comments, which I've addressed.

I'll have a look tomorrow.

(for future reference, please do feel encouraged to needinfo me for questions/verifications like this :-) )

Comment 6

[:Gijs (he/him)]

LGTM! Is this ready to be marked fixed?

Comment 7

[Will Bamberg [:wbamberg]]

I think so, yes, but Mathew raised it, so let's ask him.

Comment 8

[Mathew Hodson]

Looks good.