1119148 - [FFOS7715 v2.1] [dolphin] Enable both SIM1's and SIM2's PIN1, with wrong PIN1 codes, SIM1's PUK1 will not pop up

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Yang Yang]

Attachment: 0-main-20-13-39.log

[1.Testing Steps]: 
Precondition : Enable both SIM1's and SIM2's PIN1.
1. Boot the device.
2. Enter wrong PIN code(for SIM1) for 3 times when the PIN UI displayed.
3. Enter wrong PIN code(for SIM2) for 3 times when the PIN UI displayed.

[2.Expected Result]: 
1.Both SIM1's and SIM2's PUK1 code should pop up to prompt the user input PUK1 code.

[3.Actual Result]: 
1.The SIM1's PUK1 code will not pop up and no SIM1 signal shows on notifications bar.

[4.Reproduction Frequency]: 
Always Recurrence,5/5

Comment 1

[Yang Yang]

Attachment: 0-radio-20-13-39.log

Comment 2

[Yang Yang]

I have analyse this problem and find the problem is caused by the codes below:

gaia/apps/system/sim_lock.js

function showIfLocked()

if (SimPinDialog.visible ? !skipped : skipped) {
     return false;
}

because after enter wrong sim1 pin1 code for 3 times, there wil show the sim2 pin dialog,
with this condition （SimPinDialog.visible ? !skipped : skipped）, sim1's PUK1 code can not
pop up


although this problem is find in FFOS7715 v2.1, i think the master branch has the same problem

Comment 3

[Yang Yang]

although i have found the problem, i have not a solution to solve this problem

alive, do you have any idea to improve this problem, thank you

Comment 4

[Yang Yang]

I found the conditon （SimPinDialog.visible ? !skipped : skipped） is added for bug 1007948,
Alberto, do you think this conditon can cause this bug's problem, thank you

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Transfer ni

Comment 6

[Alberto Pastor [:albertopq]]

It shouldn't, in theory.. SimPinDialog is treating in the same way PIN and PUK, so it should show the PUK dialog. I would need to debug it, but I don't have any SIM's PUK code. Let me try to get one and check what's going on.

Comment 7

[Yang Yang]

(In reply to Alberto Pastor [:albertopq] from comment #6)
> It shouldn't, in theory.. SimPinDialog is treating in the same way PIN and
> PUK, so it should show the PUK dialog. 

Because SimPinDialog is treating in the same way PIN and PUK,
so if sim2's PIN is open, sim1's PUK will not open,
just like if sim1's PIN is open, sim2's PIN will not open.

Alberto, do you have any progress of this problem, thank you.

Comment 8

[Alberto Pastor [:albertopq]]

We need to refactor all the SIM management for having 1 different instance of the SIM dialog for each sim card. I'll try to work on this during this week. I'll let you know as soon as I have something to see if you can collaborate. Thanks!

Comment 9

[BMO Automation]

Firefox OS is not being worked on