Closed
Bug 1119184
Opened 9 years ago
Closed 9 years ago
Securemail incorrectly displays " You will have to contact bugzilla-admin@foo to reset your password." for whines
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: dkl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
1.92 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
Broken out from bug 815284. For whines, if the email needs encrypting, securemail currently outputs: { This email would have contained sensitive information, but you have not set a PGP/GPG key or SMIME certificate in the "Secure Mail" section of your user preferences. You will have to contact bugzilla-admin@mozilla.org to reset your password. } We need an additional ELSIF here, since it's not enough to assume !bug_id means password reset: https://github.com/mozilla/webtools-bmo-bugzilla/blob/cf7ddf8474fa15955e409d28b2956c6749407f6f/extensions/SecureMail/template/en/default/account/email/encryption-required.txt.tmpl#L13
Assignee | ||
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8545986 [details] [diff] [review] 1119184_1.patch Review of attachment 8545986 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for looking at this so quickly! :-) With this patch, whines are not shown the "In order to receive the full text of similar mails in the future, please go to:" message that is applicable to them. Perhaps the bud_id conditional path could be split up?
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8545986 -
Attachment is obsolete: true
Attachment #8545986 -
Flags: review?(glob)
Attachment #8546088 -
Flags: review?(glob)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8546088 [details] [diff] [review] 1119184_2.patch Review of attachment 8546088 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/SecureMail/template/en/default/account/email/encryption-required.txt.tmpl @@ +10,3 @@ > > You can see this bug's current state at: > [%+ urlbase %]show_bug.cgi?id=[% bug_id %] An additional |IF bug_id| is needed around this last paragraph, since there is no bug_id for multi-bug whines.
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #4) > Comment on attachment 8546088 [details] [diff] [review] > 1119184_2.patch > > Review of attachment 8546088 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: > extensions/SecureMail/template/en/default/account/email/encryption-required. > txt.tmpl > @@ +10,3 @@ > > > > You can see this bug's current state at: > > [%+ urlbase %]show_bug.cgi?id=[% bug_id %] > > An additional |IF bug_id| is needed around this last paragraph, since there > is no bug_id for multi-bug whines. Oops. good catch. New patch.
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8546088 -
Attachment is obsolete: true
Attachment #8546088 -
Flags: review?(glob)
Attachment #8546092 -
Flags: review?(glob)
Comment on attachment 8546092 [details] [diff] [review] 1119184_3.patch Review of attachment 8546092 [details] [diff] [review]: ----------------------------------------------------------------- r=glob
Attachment #8546092 -
Flags: review?(glob) → review+
Assignee | ||
Comment 8•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git cc0c733..5bf6a94 master -> master
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: Extensions: SecureMail → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•