Securemail incorrectly displays " You will have to contact bugzilla-admin@foo to reset your password." for whines

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emorley, Assigned: dkl)

Tracking

(Blocks 1 bug)

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

5 years ago
Broken out from bug 815284.

For whines, if the email needs encrypting, securemail currently outputs:

{
This email would have contained sensitive information, but you have not set
a PGP/GPG key or SMIME certificate in the "Secure Mail" section of your user
preferences.

You will have to contact bugzilla-admin@mozilla.org to reset your password.
}

We need an additional ELSIF here, since it's not enough to assume !bug_id means password reset:
https://github.com/mozilla/webtools-bmo-bugzilla/blob/cf7ddf8474fa15955e409d28b2956c6749407f6f/extensions/SecureMail/template/en/default/account/email/encryption-required.txt.tmpl#L13
Assignee

Comment 1

5 years ago
Posted patch 1119184_1.patch (obsolete) — Splinter Review
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #8545986 - Flags: review?(glob)
Reporter

Comment 2

5 years ago
Comment on attachment 8545986 [details] [diff] [review]
1119184_1.patch

Review of attachment 8545986 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for looking at this so quickly! :-)

With this patch, whines are not shown the "In order to receive the full text of similar mails in the future, please
go to:" message that is applicable to them. Perhaps the bud_id conditional path could be split up?
Assignee

Comment 3

5 years ago
Posted patch 1119184_2.patch (obsolete) — Splinter Review
Attachment #8545986 - Attachment is obsolete: true
Attachment #8545986 - Flags: review?(glob)
Attachment #8546088 - Flags: review?(glob)
Reporter

Comment 4

5 years ago
Comment on attachment 8546088 [details] [diff] [review]
1119184_2.patch

Review of attachment 8546088 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/SecureMail/template/en/default/account/email/encryption-required.txt.tmpl
@@ +10,3 @@
>  
>  You can see this bug's current state at:
>  [%+ urlbase %]show_bug.cgi?id=[% bug_id %]

An additional |IF bug_id| is needed around this last paragraph, since there is no bug_id for multi-bug whines.
Assignee

Comment 5

5 years ago
(In reply to Ed Morley [:edmorley] from comment #4)
> Comment on attachment 8546088 [details] [diff] [review]
> 1119184_2.patch
> 
> Review of attachment 8546088 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> extensions/SecureMail/template/en/default/account/email/encryption-required.
> txt.tmpl
> @@ +10,3 @@
> >  
> >  You can see this bug's current state at:
> >  [%+ urlbase %]show_bug.cgi?id=[% bug_id %]
> 
> An additional |IF bug_id| is needed around this last paragraph, since there
> is no bug_id for multi-bug whines.

Oops. good catch. New patch.
Assignee

Comment 6

5 years ago
Attachment #8546088 - Attachment is obsolete: true
Attachment #8546088 - Flags: review?(glob)
Attachment #8546092 - Flags: review?(glob)
Comment on attachment 8546092 [details] [diff] [review]
1119184_3.patch

Review of attachment 8546092 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8546092 - Flags: review?(glob) → review+
Assignee

Comment 8

5 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   cc0c733..5bf6a94  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.