Closed Bug 1119230 Opened 9 years ago Closed 9 years ago

Remove lingering PJS JIT bits

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(2 files)

The initial jit removal left behind some bits here and there, including in the public API, that are now (after other cleanups in the context code and GC) easy to remove.
Attachment #8545927 - Flags: review?(shu)
The previous patch may have been premature, because here are yet more removals.  Feel free to r- these if you want them merged or if you have another scheme in mind than peacemeal hacking away at things until they're all gone.  (This one #if 0's most of ForkJoin.cpp.)

(Like the previous patch this one contains a point fix for the GC code.)
Attachment #8545973 - Flags: review?(shu)
Comment on attachment 8545927 [details] [diff] [review]
Remove sundry JIT bits

Review of attachment 8545927 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Could you exclude the VMFunction changes? I will remove that more completely and simplify all the template hoohah in that file as well.
Attachment #8545927 - Flags: review?(shu) → review+
Comment on attachment 8545973 [details] [diff] [review]
Remove yet more JIT bits

Review of attachment 8545973 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsinfer.h
@@ +119,5 @@
>  
>  /*
>   * Execution Mode Overview
>   *
> + * JavaScript code executes sequentially.  Functions which have similar but not identical

Nit: Could you M-q the entire paragraph?
Attachment #8545973 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/2ff00342d088
https://hg.mozilla.org/mozilla-central/rev/d43317c1d73f
Assignee: nobody → lhansen
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: