1119236 - tracking bug for build and release of Firefox and Fennec 36.0

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Rail Aliiev [:rail]]

This includes betas and release

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I'm doing 36.0b1, and rail has the rest.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Set up patcher config for 35.0build3 --> 36.0b1 partial

The aim is to add all the info for 35.0build3 to the beta patcher config, so that we can specify that in ship-it and have partials generated and tested automatically. Ideally we'd have 35.0build2 as well, based on ADI, but the machinery doesn't know how to deal with two builds with the same version. Anyway, most people should have updated build2 -> build3 by the time we ship 36.0b1.

I was able to do a bump from this to 36.0b1 without hitting any errors (faked out the 36.0b1 buildID), and the linux64 update verify config bumped fine too.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8547788 [details] [diff] [review]
[tools] Set up patcher config for 35.0build3 --> 36.0b1 partial

Review of attachment 8547788 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty straightforward to me.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8547788 [details] [diff] [review]
[tools] Set up patcher config for 35.0build3 --> 36.0b1 partial

https://hg.mozilla.org/build/tools/rev/84f3e5e3ee6d

Comment 5

[Rail Aliiev [:rail]]

Attachment: add_mar-channel-ids.diff

We had some update verification errors like this:

Retrieving 'http://stage.mozilla.org/pub/mozilla.org//firefox/candidates/36.0b2-candidates/build1/win32/de/Firefox Setup 36.0b2.exe' from cache...
PATCH DIRECTORY ../../update
INSTALLATION DIRECTORY .
WORKING DIRECTORY .
failed: 22
calling QuitProgressUI
FAIL: update status was not succeeded: failed: 22
FAIL: check_updates returned failure for WINNT_x86-msvc downloads/Firefox Setup 35.0.exe vs. downloads/Firefox Setup 36.0b2.exe: 1


Error 22 means 
#define MAR_CHANNEL_MISMATCH_ERROR 22

Sounds like we need to override the update channels before we try to update.

The patch should solve the issue. The second hunk is generated by:

python tools/scripts/updates/create-update-verify-configs.py \
 -c tools/release/patcher-configs/mozBeta-branch-patcher2.cfg \
 --platform win32 --output tools/release/updates/mozBeta-firefox-win32.cfg \
 --release-config-file mozilla/release-firefox-mozilla-beta.py \
 -b https://hg.mozilla.org/build/buildbot-configs --channel beta-localtest \
 -t FIREFOX_36_0b2_RELEASE

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 8552468 [details] [diff] [review]
add_mar-channel-ids.diff

Review of attachment 8552468 [details] [diff] [review]:
-----------------------------------------------------------------

Looks sensible to me. Make sure you retag with _RELEASE_RUNTIME!

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8552468 [details] [diff] [review]
add_mar-channel-ids.diff

remote:   https://hg.mozilla.org/build/tools/rev/a6d710e4ab28
remote:   https://hg.mozilla.org/build/tools/rev/04f007605847

Comment 8

[Rail Aliiev [:rail]]

Attachment: WNP.diff

Comment 9

[Rail Aliiev [:rail]]

Attachment: RC.diff

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 8564798 [details] [diff] [review]
RC.diff

I'll update it with WNP

Comment 11

[Rail Aliiev [:rail]]

Attachment: RC+WNP.diff

Comment 12

[Rail Aliiev [:rail]]

Attachment: RC+WNP.diff

We have beta 10

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 8565616 [details] [diff] [review]
RC+WNP.diff

https://hg.mozilla.org/build/buildbot-configs/rev/8bef1c3063a1

Comment 14

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/8bef1c3063a1

Comment 15

[[e-mail] (:bhearsum)]

Comment on attachment 8565616 [details] [diff] [review]
RC+WNP.diff

Review of attachment 8565616 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/release-firefox-mozilla-release.py.template
@@ +46,3 @@
>  }
> +# What's New Page for Hello TODO: remove on request
> +releaseConfig['openURL'] = 'https://www.mozilla.org/%locale%/firefox/{{ appVersion }}/whatsnew/?oldversion=%OLD_VERSION%'

The lower case %locale% caused bug 1136143. Need to use upper case next time!

Comment 16

[Rail Aliiev [:rail]]

Attachment: fix_locale.diff

Just to follow up bug 1136143

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8568538 [details] [diff] [review]
fix_locale.diff

https://hg.mozilla.org/build/buildbot-configs/rev/8d9202cbf770

Comment 18

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/8d9202cbf770