Closed Bug 1119368 Opened 8 years ago Closed 8 years ago

Enable in-content preferences for EARLY_BETA_OR_EARLIER before Beta 36

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 37
Iteration:
37.3 - 12 Jan
Tracking Flags:
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Keywords: qawanted)

Attachments

(1 file)

Patch
948 bytes, patch
Gijs
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
To expand the testing coverage of in-content preferences as we target the 38 release train, we should begin enabling in-content preferences for EARLY_BETA_OR_EARLIER starting in Firefox 36.
Attached patch Patch — — Splinter Review 

        Attachment #8546042 -
        Flags: review?(gijskruitbosch+bugs)
Iteration: --- → 37.3 - 12 Jan
Points: --- → 1
Flags: firefox-backlog+
Flags: qe-verify-

    
    

    
  
Comment on attachment 8546042 [details] [diff] [review]
Patch

Iiiinteresting. Are you sure we're ready? :-)

rs=me for the code change.

        Attachment #8546042 -
        Flags: review?(gijskruitbosch+bugs) → review+

    
    

    
  
(In reply to :Gijs Kruitbosch from comment #2)
> Comment on attachment 8546042 [details] [diff] [review]
> Patch
> 
> Iiiinteresting. Are you sure we're ready? :-)

Yeah, I talked with Dolske about it before filing and the extra testing will help be necessary if we want to hit 38.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1b59426310d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37

    
    

    
  
Comment on attachment 8546042 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: new feature that we want to expand the testing coverage of
[User impact if declined]: less testing coverage
[Describe test coverage new/current, TBPL]: some automated tests for in-content preferences, good usage by users 
[Risks and why]: no known risks, but want to grow the number of users using it to see if there are any new issues that will surface
[String/UUID change made/needed]: none

        Attachment #8546042 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8546042 [details] [diff] [review]
Patch

Cool news!

        Attachment #8546042 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
I thought the plan was to let this ride to beta in 37?
Flags: needinfo?(jaws)

    
    

    
  
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #9)
> I thought the plan was to let this ride to beta in 37?

The private email thread and this bug always mentioned it being available in beta 36. That would give us two half-beta cycles of exposure before 38 hits beta. Was there somewhere else where you saw beta 37?
Flags: needinfo?(jaws) → needinfo?(gavin.sharp)

    
    

    
  
I was expecting one cycle, not too. But this is fine I guess.
Flags: needinfo?(gavin.sharp)

          You need to log in
          before you can comment on or make changes to this bug.