Closed
Bug 1119423
Opened 10 years ago
Closed 10 years ago
possible dereferencing of null pointer in gfxFontFamily::FindFontForChar
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
The null-test in the conditional expression at
http://hg.mozilla.org/mozilla-central/annotate/d480b3542cc2/gfx/thebes/gfxFontEntry.cpp#l1466
looks backwards; surely we want to use *aMatchData->mStyle if it's NOT null, and the default style if it is.
This code was introduced in bug 705594.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8546078 -
Flags: review?(jdaggett)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8546078 [details] [diff] [review]
Fix reversed test of aMatchData->mStyle in gfxFontFamily::FindFontForChar
argh, yup!
Attachment #8546078 -
Flags: review?(jdaggett) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Target Milestone: --- → mozilla37
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•