Closed Bug 1119423 Opened 7 years ago Closed 7 years ago

possible dereferencing of null pointer in gfxFontFamily::FindFontForChar

Categories

(Core :: Graphics: Text, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

The null-test in the conditional expression at

http://hg.mozilla.org/mozilla-central/annotate/d480b3542cc2/gfx/thebes/gfxFontEntry.cpp#l1466

looks backwards; surely we want to use  *aMatchData->mStyle  if it's NOT null, and the default style if it is.

This code was introduced in bug 705594.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment on attachment 8546078 [details] [diff] [review]
Fix reversed test of aMatchData->mStyle in gfxFontFamily::FindFontForChar

argh, yup!
Attachment #8546078 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/a9321d31e47c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.