1119428 - Reset PIN logged me out and hung

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Andy McKay]

Attachment: reset-pin.mov

On 2.1 device.

1. Login
2. Try to purchase an app
3. Click reset PIN

Expected:

Enter my password into Firefox Accounts.

Actual:

Flashes a persona message.
Completely logs me out of Firefox Accounts.
Hangs on a spinner.

Taking videos on the phone is hard, all but the last step occurred on simulator:

Comment 1

[Stuart Colville [:muffinresearch]]

Seems like bug 1103103 wasn't actually resolved. 

I'll add dealing with removing the reset click page in the click page removal branch.

Comment 2

[Stuart Colville [:muffinresearch]]

Or actually it's probably going to be better to handle it independently for easier review.

Comment 3

[Stuart Colville [:muffinresearch]]

So this bug is because NativeFxA logout isn't working correctly (Or rather it's not working like the old persona code expects - the old persona code was re-jigged for native FxA to use here: https://github.com/mozilla/spartacus/commit/d743620ee4213798611e96b89a39bbeb67cbabf3). So we're hanging at the logout which never resolves.

Not sure what the native API's expectations are here. Clearly this is a point where the native FxA API differs from Persona.

Comment 4

[Stuart Colville [:muffinresearch]]

Attachment: logout-log.txt

Adding a log which appears to show logout getting fired twice by indentity on the native API.

Not sure if it's expected we should call navigator.mozId.logout.

Comment 5

[Stuart Colville [:muffinresearch]]

Attachment: logout-log.txt

Comment 6

[Stuart Colville [:muffinresearch]]

I think this is why things go strange as logout handlers are called twice at our end as we are responding to 2 onlogout events.

Comment 7

[krupa raj[:krupa]]

We also need to make sure that logging out of Marketplace (during Forgot PIN flow) doesn't log the user out of the phone. More details in https://bugzilla.mozilla.org/show_bug.cgi?id=1073177

Comment 8

[Allen Short [:ashort]]

 https://github.com/mozilla/spartacus/commit/8152657103dc77a264ccf4e9231255e95b43c392