1119443 - Docker's generate_bmo_data.pl doesn't have similar bug status settings

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Developer Box, defect)

Description

[Gregory Szorc [:gps]]

The bug status values and transitions in the Docker BMO setup don't resemble BMO at all. This is making it difficult to test things that involve bug status changes.

The BMO bug status values and transitions should be added to generate_bmo_data.pl.

Comment 1

[Gregory Szorc [:gps]]

Attachment: patch

This patch should be sufficient for a proper patch to be committed.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8546150 [details] [diff] [review]
patch

Review of attachment 8546150 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Thanks for looking at this as statuses was on my punch list for adding to this script. 

For reference to how this done by the Bugzilla code for a new database see:
http://git.mozilla.org/?p=webtools/bmo/bugzilla.git;a=blob;f=Bugzilla/Install.pm;h=d5f4f04cdb31626815402e82044b036b7cfb7761;hb=refs/heads/master#l285 [github]

But you're way accomplish same and I am not fussed either way. One thing I can add or if you want to
do it is to add the 'INCOMPLETE' resolution which is the only one added for BMO apart from upstream.

f=dkl

::: contrib/docker/generate_bmo_data.pl
@@ +606,5 @@
> +        transitions => [['UNCONFIRMED', 0], ['REOPENED', 0], ['RESOLVED', 0]],
> +    },
> +);
> +
> +if (!$dbh->selectrow_array("SELECT 1 FROM bug_status WHERE value = 'ASSISGNED'")) {

s/ASSISGNED/ASSIGNED/

@@ +609,5 @@
> +
> +if (!$dbh->selectrow_array("SELECT 1 FROM bug_status WHERE value = 'ASSISGNED'")) {
> +    $dbh->do('DELETE FROM bug_status');
> +    $dbh->do('DELETE FROM status_workflow');
> +

Add:

print "updating statuses and workflow...\n";

@@ +628,5 @@
> +            $old_id = undef;
> +        }
> +
> +        foreach my $transition (@{$status->{transitions}}) {
> +            print "New status: " . $transition->[0] . "\n";

No need to print this information.

Comment 3

[Gregory Szorc [:gps]]

Attachment: patch

Here it is with the small nits addressed. I won't be offended if you clean this up and/or add the INCOMPLETE resolution to it before landing.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8546391 [details] [diff] [review]
patch

Review of attachment 8546391 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl. Thanks for the help. Will commit in all the needed places.

Comment 5

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   2bf5ed2..ec05da4  master -> master