Closed Bug 1119450 Opened 11 years ago Closed 11 years ago

Search popup shouldn't open when clicking on the search go button

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 37
Iteration:
37.3 - 12 Jan
Tracking Flags:
Tracking Status
firefox35 - wontfix
firefox36 + verified
firefox37 + verified

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1119450: Clicks on the search go button shouldn't open the search popup.
39 bytes, text/x-review-board-request
Felipe
: review+
Details
The go button launches a search, it shouldn't reopen or open the popup too.
Flags: firefox-backlog+
Is this a regression from bug 1103455 too? Or did we ship this in 34?
Flags: needinfo?(dtownsend)
Yeah cause by bug 1103455, using the click handler specifically so with a fix we may want to uplift to 35 if possible, I don't think it's important enough to rush though
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
tracking-firefox35: --- → ?
tracking-firefox36: --- → ?
tracking-firefox37: --- → ?
Depends on: 1103455
Flags: needinfo?(dtownsend)
Attached file MozReview Request: bz://1119450/Mossop (obsolete) —
Attachment #8546772 - Flags: review?(florian)
Attachment #8546772 - Flags: review?(felipc)
/r/2295 - Bug 1119450: Clicks on the search go button shouldn't open the search popup. Pull down this commit: hg pull review -r 0f7fa4e6e6cc833a41cac28288bdce38722815a7
Then again this is pretty trivial so let's see whether we can make it. Try is running now but this is simple enough that I expect it to pass.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Iteration: --- → 37.3 - 12 Jan
Points: --- → 1
Flags: qe-verify-
Attachment #8546772 - Flags: review?(felipc) → review+
Attachment #8546772 - Flags: review?(florian)
https://hg.mozilla.org/mozilla-central/rev/4c7198e714b0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Flags: qe-verify- → qe-verify+
Comment on attachment 8546772 [details] MozReview Request: bz://1119450/Mossop Approval Request Comment [Feature/regressing bug #]: bug 1103455 [User impact if declined]: The search suggestions re-open after clicking the search go button [Describe test coverage new/current, TBPL]: Automated tests running on m-c since landing [Risks and why]: Low risk, the product code change only involves ignoring clicks to a particular element. [String/UUID change made/needed]: None
Attachment #8546772 - Flags: approval-mozilla-beta?
QA Contact: petruta.rasa
Attachment #8546772 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed using Firefox Developer Edition 37.0a2 2014-01-14 under Win 7 64-bit, Ubuntu 12.04 32-bit and Mac OSX 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox37: fixed → verified
The issue still reproduces on Firefox 36 beta 1 - build 2 (the bug appears as uplifted in changelog).
status-firefox36: fixed → affected
Flags: needinfo?(dtownsend)
(In reply to Petruta Rasa [QA] [:petruta] from comment #12) > The issue still reproduces on Firefox 36 beta 1 - build 2 (the bug appears > as uplifted in changelog). Which changelog are you referring to? The uplifted changeset to fix this wasn't included in build 2 (which was just build 1 with a single change to re-enable flash protected mode).
status-firefox36: affected → fixed
Flags: needinfo?(dtownsend)
Sorry, I saw it in this link: https://hg.mozilla.org/releases/mozilla-beta/log/242873 I'll verify again in Firefox 36 beta 2.
Verified as fixed using Firefox 36 beta 2 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
status-firefox36: fixed → verified
Attachment #8546772 - Attachment is obsolete: true
Attachment #8619080 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: