Closed Bug 1119452 Opened 9 years ago Closed 9 years ago

[RTL][Camera] Options menu items are shifted off the screen.

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.2+, b2g-v2.2 verified)

VERIFIED FIXED
feature-b2g 2.2+
Tracking Status
b2g-v2.2 --- verified

People

(Reporter: ychung, Assigned: nefzaoui)

References

Details

Attachments

(4 files)

Attached image CameraOptions.png
Description:
In the Camera app, the Options menu items are shifted off the screen.

Repro Steps:
1) Update a Flame device to BuildID: 20150108010221.
2) Set the device language in Arabic under Settings > Language.
3) Open Camera app.
4) Select the Options drawer.

Actual:
The menu items are shifted off screen to the left.
  
Expected: 
The menu items are displayed properly on screen.

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150108010221
Gaia: d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko: 70de2960aa87
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: screenshot
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Whiteboard: [systemsfe]
No longer blocks: camera-rtl
Blocks: camera-rtl
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
Decided this morning we should block on this for 2.2
blocking-b2g: --- → 2.2?
This is the media team's bug, not sysfe
Whiteboard: [systemsfe]
Priority: -- → P1
Blocking per RTL triage for 2.2
blocking-b2g: 2.2? → 2.2+
Comment on attachment 8554776 [details] [review]
[PullReq] anefzaoui:bug-1119452 to mozilla-b2g:master

hey Mike,
how does that look?
Thanks!
Attachment #8554776 - Flags: review?(mhabicher)
Comment on attachment 8554776 [details] [review]
[PullReq] anefzaoui:bug-1119452 to mozilla-b2g:master

Over to you, Wilson.
Attachment #8554776 - Flags: review?(mhabicher) → review?(wilsonpage)
RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)
blocking-b2g: 2.2+ → ---
feature-b2g: --- → 2.2+
Ni Wilson for review and assigning to Ahmed who is working on the patch (thanks Ahmed for fixing this!)
Assignee: nobody → nefzaoui
Flags: needinfo?(wilsonpage)
Flags: in-moztrap+
Attached image options-title-rtl.png
At some point the RTL layout of the options title has regressed. I'm not sure if this is a result of this patch or not. Either way, it should be fixed here.
Flags: needinfo?(wilsonpage) → needinfo?(nefzaoui)
Comment on attachment 8554776 [details] [review]
[PullReq] anefzaoui:bug-1119452 to mozilla-b2g:master

Left comments on Github.
Attachment #8554776 - Flags: review?(wilsonpage)
Turns out this one of the bugs caused by bug 1121748.
This is verified fixed in 2.2 after the backout of the patch that caused the gecko issue, still regressing in 3.0.
Depends on: 1121748
Flags: needinfo?(nefzaoui)
Should this be marked as status-b2g-v2.2 fixed or unaffected then? (In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #11)
> This is verified fixed in 2.2 after the backout of the patch that caused the
> gecko issue, still regressing in 3.0.

Should this be marked as status-b2g-v2.2 fixed or unaffected then?
Flags: needinfo?(wilsonpage)
Confirmed fixed on 'master' (v3.0)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(wilsonpage)
Resolution: --- → FIXED
Marking 2.2-fixed per comment #11.
Hi Yeojin,
   I verify this bug on latest Flame 2.2,the "2 seconds" option is translated to Arabic, but it is different from the other two option. So I can't make sure the bug is fixed or not. Could you hlep to confirm it? Thanks!
Attachmnet:RTL_Camera.png.

Flame 2.2 build:

Build ID               20150210002516
Gaia Revision          b30c8e4303595a0fcb5b640d673cf8503b954701
Gaia Date              2015-02-10 04:09:47
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3e9fa4e70a1b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150210.041059
Firmware Date          Tue Feb 10 04:11:10 EST 2015
Bootloader             L1TC000118D0
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage+][rtl-impact], [MGSEI-Triage+]
Flags: needinfo?(ychung)
Attached image RTL_Camera.png
(In reply to Coler from comment #15)
> Hi Yeojin,
>    I verify this bug on latest Flame 2.2,the "2 seconds" option is
> translated to Arabic, but it is different from the other two option. So I
> can't make sure the bug is fixed or not. Could you hlep to confirm it?
> Thanks!

It looks like "ثانيتين" is the right translation for 2 seconds (http://transvision-beta.mozfr.org/?recherche=2+seconds&repo=gaia&sourcelocale=en-US&locale=ar&search_type=strings).

Ahmed, could you confirm this please?
Flags: needinfo?(ychung) → needinfo?(nefzaoui)
Ahmed explained to me the other day about plural forms in Arabic the following: "one", "two" and "zero" are defined within the actual word. So no need to add a number.
Thus clearing the ni for Ahmed :)
Flags: needinfo?(nefzaoui)
OK, thank all!
Status: RESOLVED → VERIFIED
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15341/
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: