1119528 - [RTL][Search] Close button is overlapping the x icon in the search bar

Status: VERIFIED DUPLICATE of bug 1121748

(Firefox OS Graveyard :: Gaia::Search, defect, P1)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Description:
The "Close" button is overlapping the "x" icon in the search bar.

Repro Steps:
1) Update a Flame device to BuildID: 20150108010221.
2) Set the device language in Arabic under Settings > Language.
3) Tap on the "Rocketbar" on the home screen and type in some text.
4) Observe the "Close" button and the "x" icon.

Actual:
The "Close" button is overlapping the "x" icon.
  
Expected: 
No overlapping occurs.

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150108010221
Gaia: d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko: 70de2960aa87
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100% 5/5
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: CloseButtonOverlap.jpg

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Decided during triage this morning that this would in fact block 2.2

Comment 3

[bhavana bajaj [:bajaj]]

Blocking per RTL triage for 2.2

Comment 4

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

qawanted to see if this is still an issue.

Comment 6

[Kevin Grandon :kgrandon]

I think this is resolved now, please verify. There was another bug which did RTL for search/rocketbar, but I can't remember the bug number right now.

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is only fixed on 2.2, it still occurs on 3.0 builds. (When the issue was reported 2.2 was central, but is not anymore.)

Issue is FIXED

Environmental Variables:
Device: Flame 2.2
BuildID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Issue is NOT fixed

Environmental Variables:
Device: Flame 3.0
BuildID: 20150202154235
Gaia: 4171327fce4803c52b2fae8071b114a70a3a68a7
Gecko: 3bf7ed413e87
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 8

[Coler]

This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5.
Attachment: Verify_RTL_Closebutton.png.

Flame2.2 build:

Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be206fa2fb60
Build-ID        20150202002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150202.035604
FW-Date         Mon Feb  2 03:56:15 EST 2015
Bootloader      L1TC000118D0

Comment 9

[Coler]

Attachment: Verify_RTL_Closebutton.png

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> I think this is resolved now, please verify. There was another bug which did
> RTL for search/rocketbar, but I can't remember the bug number right now.

Kevin, any ideas on why this might be fixed in 2.2 and not on master?

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Michael Henretty [:mhenretty] from comment #10)
> Kevin, any ideas on why this might be fixed in 2.2 and not on master?

If I was a betting man, I'd say that bug 1121748 is causing weirdness here too.

Comment 12

[Kevin Grandon :kgrandon]

Let's see what happens with bug 1121748. If it still exists after that's fixed I'll take a look. Not sure what's going on off the top of my head unfortunately.

Comment 13

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15445/

Comment 14

[Josh Cheng [:josh]]

Dear Candice,
Can you help to find someone help on this bug?
Thanks!

Comment 15

[Candice Serran (:cserran)]

ni'ing Michael for update and assignment

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Marking as dupe of bug 1121748. Let's get this verified on master.

Comment 17

[SandKing]

This issue has been make as verified for flame 3.0 on bug 1121748,
So clear the keywords

Comment 18

[Lancy(Leave from Mozilla)]

Attachment: Verify2_master.png

Bug 1121748 has been verified as pass, and this issue is verified as pass on latest Flame&N5 master build by the same STR in comment 0, close button does not overlap with the x icon in the search bar.

See attachment:Verify2_master.png.
Reproducing rate: 0/10

Flame master build (Pass):
Build ID               20150728030208
Gaia Revision          14e32276025b0310d3e89027320cf4b2a24cedfb
Gaia Date              2015-07-27 16:43:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/33dc8a83cfc0
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150728.064331
Firmware Date          Tue Jul 28 06:43:41 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

N5 master build (Pass):
Build ID               20150728150207
Gaia Revision          862f0895f3f5a97200601542d99a152a46385a0b
Gaia Date              2015-07-28 15:30:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/833403badc41
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150728.182857
Firmware Date          Tue Jul 28 18:29:15 EDT 2015
Bootloader             HHZ12f