1119561 - [Cost Control][Settings] Reset Confirmation warning displays inaccurate usage value the first time it is selected.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-Usage-Data.txt

Description:
When in the Usage app, if user navigates to Settings and selects one of the Reset options, they are presented with a Confirmation dialog warning displaying the current data value(s) they are about to reset, asking if they truly want to continue.  The first time they select any of the three reset options, the value reported in the Confirmation warning will be lower than the values displayed elsewhere in the usage app.  If they select 'Cancel', the user will observe the data values appear to reload, and any further confirmation warnings displayed will show accurate usage data.

Notes:
-This occurs every time the usage app is closed and relaunched
-This occurs on both SIM 1 and SIM 2.  Dual SIMs are NOT required for this to occur.
-This occurs when selecting 'Reset Wi-Fi usage,' 'Reset mobile usage,' and 'Reset mobile & Wi-Fi data.'
-Depending on how much data usage has been recorded, the initial inaccurate value may be as low as '0.00 B'
-If the user selects 'Yes' to confirm data reset, the value will still be fully reset back to zero

Repro Steps:
1) Update a Flame device to BuildID: 20150108010221
2) Initialize the Usage app to track WiFi and Cellular data usage
3) Close the Usage app and browse the web to generate some usage data
4) Return to the Homescreen and relaunch the Usage app
5) Tap the Gear icon to open the Settings screen
6) Note the Usage values at the top of the screen, then select the Reset button
7) Select ''Reset mobile usage.' Note the data value displayed in the Confirmation dialog
8) Select 'Cancel' and wait for the data values to reload
9) Select the Reset button, then select Reset mobile usage' again. Note the new data value.
  
Actual:
Data value displayed in the first Confirmation Warning is lower than the value displayed in the second Confirmation Warning and elsewhere in the Usage app
  
Expected: 
Data value displayed in the first Confirmation Warning is accurate and consistent with the second Confirmation Warning and elsewhere in the Usage app
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150108010221
Gaia: d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko: 70de2960aa87
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Notes: This issue occurs on both v188-1 and v18D bases
  
Repro frequency: 10/10
See attached: video clip (URL), logcat

---------------------------------------------------------------------

This issue does NOT occur on Flame 2.1.
The Reset Warning Prompt is not implemented on this branch.  Selecting reset options will reset the value to zero without a confirmation warning.

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150108001214
Gaia: ed2e278753e8c9301ba322dcf2c3591f5928408d
Gecko: 127a0ead5f83
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 34.0 (2.1)
Firmware: V18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 1

[Peter Bylenga [:PBylenga]]

Nominating to block, inconsistency in reporting Mobile usage deteriorates user's confidence in these values and may have financial impact.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: inconsistent information displayed to user. should block, otherwise we should back out the the feature "warning prompt".

Comment 3

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
the bug is related to "Bug 1083680: Noticeable difference between by application breakdown totals and the total displayed in chart and widget". The data query by App and the normal query differ because of exists traffic that cannot be not allocated to an App.

We can make a easy workaround to fix this issue, not caching the results of the query by App. This way we ensure that always we are showing the correct results.
WDYT?

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8548051 [details] [review]
patch v1.0

You have some commentaries on GitHub. Please, once solved, ask for my review again.

Thank you for figuring out what was happening here!

Comment 5

[Marina Rodríguez [:mai]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Updated the pr with your comments

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Hi Marina. See my comments on GitHub, please and ask for my review when you're done. Thank you!

Comment 7

[Marina Rodríguez [:mai]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing again?

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Let's simplify the test as accorded offline. Thank you Mai.

Comment 9

[Marina Rodríguez [:mai]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Hi Salva, 
would you mind reviewing the patch?

Comment 10

[Salvador de la Puente González [:salva]]

Comment on attachment 8548051 [details] [review]
patch v1.0

Nice work! You have a little nit on GitHub.
Thank you Mai.

Comment 11

[Marina Rodríguez [:mai]]

Master: 106735a99fc67452c9110dadf9be42d5665500be

Comment 12

[Marina Rodríguez [:mai]]

Comment on attachment 8548051 [details] [review]
patch v1.0

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1083680
[User impact] if declined: inconsistent information displayed to user
[Testing completed]:Yes
[Risk to taking this patch] (and alternatives if risky): low risk
[String changes made]:No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e86047fbf9eaa346cacb45fbd7d58c8b2fdc0be4

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: The correct value is displayed on the confirmation dialog when reset is selected for the first time.

Device: Flame 2.2 (319mb, full flash)
Build ID: 20150126002536
Gaia: 0518f4581a0925c0b703d730ef289ab15cbd1216
Gecko: c6aa604a7967
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150126010231
Gaia: 0f662dffef27599443cfcd790c2b39190a2b35c8
Gecko: fa91879c8428
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0