1119600 - Build gulp command to test test/jetpack-package.ini is correct

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment the uplifter must do this by hand.

We should easily be able to make a script to generate this file.

Comment 1

[Dave Townsend [:mossop]]

Another alternative is the "mach generate-addon-sdk-moz-build" script that already has to be run as part of the uplift. It could add missing tests to the manifests too.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Dave Townsend [:mossop] from comment #1)
> Another alternative is the "mach generate-addon-sdk-moz-build" script that
> already has to be run as part of the uplift. It could add missing tests to
> the manifests too.

I want to include these scripts in our travis test suite eventually, so that everyone is forced to remember to update these files when checking in new test add-ons.  This way I should avoid having to make a new commit in the addon-sdk repo for each uplift.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1970

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8604873 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1970

Note: I'm removing the gulp command to generate the ini file, since that was stripping out comments, also with the tests in place the only updates that should be required will be small now, and made obvious by a test failure which are introduced in this patch.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/10844487c67de4000edbff1304e5f80ccbc2c370
Bug 1119600 - Build gulp command to test test/jetpack-package.ini is correct

https://github.com/mozilla/addon-sdk/commit/8009a5ae920c8f01a6dfa6db8d8e742d66f48de5
Merge pull request #1970 from erikvold/1119600

Bug 1119600 - Build gulp command to test test/jetpack-package.ini is correct r=jsantell