1119654 - Autophone - remove sensitive information from autophone.ini so it can be check in

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Currently autophone.ini (or whatever autophone config file you use) may have sensitive information such as:

pulse_user
pulse_password
aws_access_key_id
aws_access_key

This prevents a production version of autophone.ini from being checked into the tree which prevents the production instance from being configured via a git push/git pull.

Currently we do use treeherder_credentials_path which if added to the production version of autophone.ini and checked in would disclose the local path of the credentials, but not the credentials themselves.

Mark, what do you think of a similar approach for pulse and aws? e.g. aws_credentials_path and aws_credentials_path ?

Comment 1

[Bob Clary [:bc] (inactive)]

err, pulse_credentials_path and aws_credentials_path of course.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: PR 29

Comment 3

[Bob Clary [:bc] (inactive)]

gbrown: fyi, in the production-manifest I edited the try only sections to not include all devices but didn't update the previous comment. I'll fix and push the branch again.

Comment 4

[Bob Clary [:bc] (inactive)]

Comment on attachment 8601674 [details] [review]
PR 29

Had a typo in the robocop config file where I used - instead of _ for the robocop_autophone.ini. This additional patch fixes that and adds another config for the full robocop test. I've adjusted their test_names to allow them both to be specified without conflicting with each other.

I was running tests at
https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=3bf223d7eedd&filter-searchStr=autophone

https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=b1d38f4141af&filter-searchStr=autophone

The rca tests for 2.3 have completed but I'll go ahead and stop the rest.

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/a2d1dec5d15b94e8737938854ec07feb876f7186
https://github.com/mozilla/autophone/commit/b6dc95d0c7268a3a61b16066be8ed81d6efd790f
https://github.com/mozilla/autophone/commit/da999ea1214e17361ec81651472a6539476bcbaa
https://github.com/mozilla/autophone/commit/b8ab294443ae3eceef21d6f0efe303817217f995
https://github.com/mozilla/autophone/commit/2e34070c47aa66c0b09b93105fb98fbec649b4f8