1119697 - [Task Manager] inconsistent behavior when tapping home button in Card View

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

As a user, I want to have similar experience when I press home button in Card View. However, currently I have 3 kinds of results.

*Current flows:
Flow 1: enter card view from homescreen -> switch to another task -> tap home button -> go back to homescreen.

Flow 2: enter card view from an app or bookmark -> switch to another task -> tap home button -> open currently centered task.

Flow 3: enter card view from a smart collection -> switch to another task -> tap home button -> go back to smart collection.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

This one is not a bug; this is a desired behavior which is implemented v2.2; I believe it is similar to iOS'  task manager behavior: press home in task manager will lead you to the original opened app.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> This one is not a bug; this is a desired behavior which is implemented v2.2;
> I believe it is similar to iOS'  task manager behavior: press home in task
> manager will lead you to the original opened app.

Moreover, I agree that we should not add too many rules to home button in order not to confuse the user.

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> This one is not a bug; this is a desired behavior which is implemented v2.2;
> I believe it is similar to iOS'  task manager behavior: press home in task
> manager will lead you to the original opened app.

The desired behavior in v2.2 spec is leading user back to the original opened app. However, current behavior is directly leading user to central app in card view as described in my flow 2.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Hermes Cheng[:hermescheng] from comment #3)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #1)
> > This one is not a bug; this is a desired behavior which is implemented v2.2;
> > I believe it is similar to iOS'  task manager behavior: press home in task
> > manager will lead you to the original opened app.
> 
> The desired behavior in v2.2 spec is leading user back to the original
> opened app. However, current behavior is directly leading user to central
> app in card view as described in my flow 2.

Okay, but that design also makes sense to me; if we open the switched app, the transition will look strange. I will leave the discussion to UX.

Comment 5

[Sam Foster [:sfoster] (he/him)]

The spec says that when you tap 'home', we slide over to the original opened app and use a zoom transition to open it and close the task manager. However, that slide was proving really difficult to transition smoothly, and without it it seemed confusing to open an app that might be outside the viewport. So we settled on opening the currently-centered app. 

Ultimately we want to use CSS scroll-snap for the horizontal scrolling and the native scrolling (scrollTo) and easing for slide transitions. But until the platform can give us that, I'm not sure we can improve this.

Comment 6

[Francis Djabri [:djabber]]

The desired behaviour for flow 2 is return the user to the original app and not open the centered card. 

If we cannot implement this with enough quality, we should return the user to the home screen for flow 2. At least this way, there's consistency that pressing home screen should always return the user to the home screen. 

This has been discussed in the etherpad at: https://etherpad.mozilla.org/task-manager-ux-review

Comment 8

[Ben Francis [:benfrancis]]

We came across this in triage, Sam would you be able to take this one?

Comment 9

[Sam Foster [:sfoster] (he/him)]

I can implement comment #6, in which home always takes you to homescreen (regardless of which app you were on when the task manager was launched)

Comment 10

[Sam Foster [:sfoster] (he/him)]

Attachment: PR: fix + unit test updates

Consensus is to make 'home' behavior consistent in task manager so we always go back to homescreen (until we can smoothly animate transition when returning to last app) Updates unit test for this and fix some calledOrder -> callOrder exceptions I was seeing

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8553860 [details] [review]
PR: fix + unit test updates

lgtm, but we probably have some integration tests to update, thankfully :)

Comment 12

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8553860 [details] [review]
PR: fix + unit test updates

Updated the marionette test. Its possible we were running into bug 1118854 - that should have failed 100% of the time in the last run. Passes locally for me, lets see what Gaia-Try has to say. Optimistically flagging for r?

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8553860 [details] [review]
PR: fix + unit test updates

worth rebasing on a better tree but lgtm!

Comment 14

[Sam Foster [:sfoster] (he/him)]

Rebased and merged to master: https://github.com/mozilla-b2g/gaia/commit/3efaeeb8bde3fc5a5e034c973a19e0fcff384c24

Comment 15

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8553860 [details] [review]
PR: fix + unit test updates

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Task Manager
[User impact] if declined: Inconsistent behavior from 'home' button in task-manager
[Testing completed]: Gaia-Try, on device
[Risk to taking this patch] (and alternatives if risky): Low risk, small system app/task-manager only patch that consolidates behavior
[String changes made]: None

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/58a7508d7e9d30f49a98294f756bbd0b8767b5ac

Comment 17

[Sam Foster [:sfoster] (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #16)
> v2.2:
> https://github.com/mozilla-b2g/gaia/commit/
> 58a7508d7e9d30f49a98294f756bbd0b8767b5ac

\o/ thanks Ryan I was just going to do this.

Comment 18

[Yeojin Chung [:YeojinC]]

Hi Sam,

On today's nightly Flame 2.2 and Master, I see the homescreen when the home button is pressed during card view with flow #1 and #2 from Comment 0. However, it goes back to the smart collection when the home button is pressed in flow #3. Is this an intended behavior? I thought the fix was to make it always returning to the homescreen, but not sure if the smart collection is an exception.

Device: Flame 2.2 (319mb, full flash)
Build ID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150202010229
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: 940118b1adcd
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 19

[Sam Foster [:sfoster] (he/him)]

> On today's nightly Flame 2.2 and Master, I see the homescreen when the home
> button is pressed during card view with flow #1 and #2 from Comment 0.
> However, it goes back to the smart collection when the home button is
> pressed in flow #3. Is this an intended behavior? I thought the fix was to
> make it always returning to the homescreen, but not sure if the smart
> collection is an exception.

I'm not sure either. But can we make a new bug for the smart collection issue and let this one stand? We can amend the title to be clear about what issue was being fixed. "Consistency in all things" bugs are never done and I would prefer to evaluate each issue individually for severity/priority.

Comment 20

[Yeojin Chung [:YeojinC]]

> I'm not sure either. But can we make a new bug for the smart collection
> issue and let this one stand? We can amend the title to be clear about what
> issue was being fixed. "Consistency in all things" bugs are never done and I
> would prefer to evaluate each issue individually for severity/priority.

Sure, I'll close this bug as verified, and open up a new bug about the smart collection issue.