User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 Build ID: 20141125180439 Steps to reproduce: 1) Have the device language set to “Polski” 2) Open the "Settings" app 3) Select Internet Sharing Actual results: The Word "Security" are truncated in Polish. Expected results: The Word "Security" don't appear truncated
Triage: blocking. Hi Helen, can you provide feedback on how the long word should be shown? e.g. switch line...etc. Thanks.
blocking-b2g: 2.2? → 2.2+
The word "Bezpieczeństwo" (security) is not that long and should fit in one line if we could change to per line styling (there is enough space) or something like that.
Yes, there is enough space for showing the word completely, I've updated the mockup for reference. Please take a look. Thanks!
Arthur, I just made a patch based on Helen's latest design. Can you help me review it ? Thanks :)
4 years ago
Assignee: nobody → ejchen
Status: NEW → ASSIGNED
Is it possible not introducing another class name? I did some experiments and it seems possible to use flexbox with some pre-conditions (like only truncating the subtitle).
btw, the experiments that I did: http://jsbin.com/movacurohi/1/edit?html,css,output
Arthur, based on our offline discussion, we all agree that these styles should be used as base styles. In this way, I just updated the patch to make it align with our ideas, can you give me some ideas about this implementation ? thanks :)
Flags: needinfo?(ejchen) → needinfo?(arthur.chen)
Looks good! Let's remove the limitation on width as what we've discussed.
This is the final look and feel when using the long word in hotspot panel.
Comment on attachment 8547996 [details] [review] patch on master How about this one, Arthur :) ?
Comment on attachment 8547996 [details] [review] patch on master r=me with the name "box-container" changed. "box-container" is too generic. How about calling it "info-item" (echos to menu-item)?
Attachment #8547996 - Flags: review?(arthur.chen) → review+
Okay, just force pushed a new commit up to origin. I will merge the code after CI is green. Thank :)
Thanks merged at master : https://github.com/mozilla-b2g/gaia/commit/9bc1a29de2f8c911062031539612aa16f84288e9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8547996 [details] [review] patch on master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): no [User impact] if declined: users using `Polski` would see truncated header inside `internet sharing` menu [Testing completed]: no, only CSS change [Risk to taking this patch] (and alternatives if risky): low [String changes made]: no
Attachment #8547996 - Flags: approval-gaia-v2.2?
4 years ago
Attachment #8547996 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Issue verified fixed on Flame 2.2 and Flame 3.0 With language set to Polish, the string "Security" in the Internet Sharing settings page is not truncated and is translated properly. Device: Flame 2.2 BuildID: 20150122002808 Gaia: e4f9b5da3751798f9cc5d95f302c30722cc11fca Gecko: 4a90da67661e Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Device: Flame 3.0 Master Build ID: 20150122010203 Gaia: 917b6c36717fddc6e71ffc1ec249633c8044c93c Gecko: 34e2d2bd7ec4 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
You need to log in before you can comment on or make changes to this bug.