1119709 - [FxOs2.2][Settings]The security word is turned in Settings-> Internet Sharing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[patryksowa0]

Attachment: bug1.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141125180439

Steps to reproduce:

1) Have the device language set to “Polski”  
2) Open the "Settings" app 
3) Select Internet Sharing




Actual results:

The Word "Security" are truncated in Polish.




Expected results:

The Word "Security" don't appear truncated

Comment 1

[howie [:howie]]

Triage: blocking.

Hi Helen, can you provide feedback on how the long word should be shown? e.g. switch line...etc.
Thanks.

Comment 2

[Stefan Plewako [:stef]]

The word "Bezpieczeństwo" (security) is not that long and should fit in one line if we could change to per line styling (there is enough space) or something like that.

Comment 3

[Helen Huang [:HHuang]]

Attachment: bug1-revise.jpg

Yes, there is enough space for showing the word completely, I've updated the mockup for reference. Please take a look. Thanks!

Comment 4

[Stefan Plewako [:stef]]

Looks good!

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Arthur, I just made a patch based on Helen's latest design. 

Can you help me review it ? Thanks :)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Is it possible not introducing another class name? I did some experiments and it seems possible to use flexbox with some pre-conditions (like only truncating the subtitle).

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

btw, the experiments that I did: http://jsbin.com/movacurohi/1/edit?html,css,output

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, based on our offline discussion, we all agree that these styles should be used as base styles. In this way, I just updated the patch to make it align with our ideas, can you give me some ideas about this implementation ? thanks :)

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Looks good! Let's remove the limitation on width as what we've discussed.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: demo with this patch.png

This is the final look and feel when using the long word in hotspot panel.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8547996 [details] [review]
patch on master

How about this one, Arthur :) ?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8547996 [details] [review]
patch on master

r=me with the name "box-container" changed. "box-container" is too generic. How about calling it "info-item" (echos to menu-item)?

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Okay, just force pushed a new commit up to origin. I will merge the code after CI is green. Thank :)

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks merged at master : https://github.com/mozilla-b2g/gaia/commit/9bc1a29de2f8c911062031539612aa16f84288e9

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8547996 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: users using `Polski` would see truncated header inside `internet sharing` menu
[Testing completed]: no, only CSS change
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2f5549e99362218cc17f0e389d4490e4e611ca60

Comment 17

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.2 and Flame 3.0

With language set to Polish, the string "Security" in the Internet Sharing settings page is not truncated and is translated properly.

Device: Flame 2.2
BuildID: 20150122002808
Gaia: e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko: 4a90da67661e
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 3.0 Master
Build ID: 20150122010203
Gaia: 917b6c36717fddc6e71ffc1ec249633c8044c93c
Gecko: 34e2d2bd7ec4
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0