111985 - Forwarding of non-ascii message as an attachment is not working correctly

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[marina]

in today's build 2001-11-26-03 i see several problems with a forwarded as an
attachment newsarticle: the file name in the message body is displaying as
"????" regardless of Mime/nomime info, manual correction doesn't work. When
chosing "Open" option from the contextual  menu the message body would display
blank in the browser ( there is no actual attachment). Same message forwarded as
an attachment to the IMAP acount would display correctly. I'll attach the
message from the Inbox and i18n.mail.qa newsgroup

Comment 1

[marina]

Attachment: here is a message from the Inbox (you see the file name and the message body showing up correctly)

Comment 2

[marina]

Attachment: this is the same message forwarded from newsgroup

Comment 3

[marina]

i see the same problem with opening an ascii newsarticle ( rightclick on the
file name in the envelope, select "Open" and note that the contents are blank in
the browser) but the file name in the envelope is showing up correctly (no "????") 

Comment 4

[marina]

nominating since this is a regression from the released version

Comment 5

[nhottanscp]

I think this is related to bug 52428 which changed to always use the system 
charset for attachment name. Looks like forward news as attachment uses the 
subject as a file name. Because news charset may vary, we cannot use the system 
charset. I think we should revert the change of bug 52428.
Reassign to ducarroz.

In attachment id=59179, the news subject is used as a file name and encoded by 
the system charset (windows-1252).

Content-Disposition: inline;
 filename="=?windows-1252?Q?=3F=3F?="

Comment 6

[Jean-Francois Ducarroz]

I don't think we should fully revert the fix for bug 52428 but rather be smarter
by looking at the sheme of the url in order to decide if we use the file system
character set or not. Accepting.

Comment 7

[Denis Antrushin]

Shouldn't we in mime_generate_attachment_headers just use attachment's charset
instead of file system charset?
I.e.,
encodedRealName = nsMsgI18NEncodeMimePartIIStr(real_name,
      charset, nsMsgMIMEGetConformToStandard());

instead of 

encodedRealName = nsMsgI18NEncodeMimePartIIStr(real_name,
      nsMsgI18NFileSystemCharset(), nsMsgMIMEGetConformToStandard());

where charset is taken from MsgAttachmentHandler

Comment 8

[marina]

changing qa contact

Comment 9

[marina]

i see it happening now with any non-ascii message regardless of mime/nomime
header. Not only with newsarticle, changing summary, nominating.

Comment 10

[marina]

This bug somehow got nsbeta- and i would like to re-nominate it and ask PDT to
reconsider. The ???? in the attachment area instead of the correct file name
look ugly and the fact that this is a regression from the shipped version has to
be attended to.

Comment 11

[marina]

i should've been more clear with this bug that has two parts ( maybe the news
bug shoul've separeted into a different bug) : 1. non-ascii attachment displays
as ??? on the envelope. 2. forward as an attachment a newsarticle ( any, ascii
as well) has no body, try to rightclick on the attachment name on the envelope
to open  it and it'll come blank. Screen shot to follow  

Comment 12

[marina]

Attachment: here is a message from the newsgroup that cames with an empty attachment

Comment 13

[Jean-Francois Ducarroz]

The problem with forwarding of a news article as been fixed recently.

Comment 14

[marina]

it is not reproducable with 2002-02-25 build, marking as fixed per J-F comments

Comment 15

[marina]

verifying as such with 2002-02-25 build