1119874 - Chromium's base::OpenProcess checks for the wrong return result

Status: RESOLVED FIXED

(Core :: IPC, defect, P3)

Description

[Jim Mathies [:jimm]]

Attachment: patch

http://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/process_util_win.cc#69

result is NULL on failure.

Fixing this causes tons of test failures on try during the initialization of PBackground.

This isn't a security issue per say, but due to the parent I'm marking it as such for now since I'm not sure if this should be made public.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I don't understand why this happens. And I can't make it happen on my Win8.1 machine...

Comment 2

[Jim Mathies [:jimm]]

I can't reproduce locally either.

Comment 3

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=4d8facdc5495

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 6

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

This was fixed as part of bug 1119878; see bug 1119878 comment #26 (search for NULL) in particular.