Closed Bug 1119931 Opened 10 years ago Closed 10 years ago

sdk/test/harness needs to reset results between each test run

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
The mochitest harness calls runTests directly for every test module but because results is cached and the same object is passed to onDone each time it can't see the per-test pass/fail counts directly. This leads to it counting the same pass/fail multiple times right now. Clearing the results object on every call to runTests solves this.
Attached file pull request
Attachment #8546832 - Flags: review?(evold)
Attachment #8546832 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/e4149a3f1978570e283751497594f934ea1594bc Bug 1119931: Reset results on each call to runTests. https://github.com/mozilla/addon-sdk/commit/3056346edeaaa6a8191352c797ddb28f95b891e9 Merge pull request #1831 from Mossop/bug1119931 Bug 1119931: Reset results on each call to runTests. r=erikvold
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: