Closed Bug 1120014 Opened 5 years ago Closed 5 years ago

Initialize mLast{Audio,Video}Time to 0, not -1

Categories

(Core :: Audio/Video, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Part of bug 1119456.
There isn't actually any initialization code that sets them at 0. Instead, we
currently rely on the fact that our first decoder ends up active regardless of
what its buffered range reports.So as long as invoking the first Request{Audio,Video}Data
is resolved, this ends up ok. But while that is usually the case, it isn't _always_
the case, especially in the case where the MP4Reader rejects with WAITING_FOR_DATA.

Flagging the union of possible reviewers. Whoever gets to it first should
clear the rest.
Attachment #8546932 - Flags: review?(kinetik)
Attachment #8546932 - Flags: review?(karlt)
Attachment #8546932 - Flags: review?(cajbir.bugzilla)
Comment on attachment 8546932 [details] [diff] [review]
Initialize MediaSourceReader::mLast{Audio,Video}Time to 0 rather than -1. v1

Review of attachment 8546932 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Missing a space after period in the third line of the commit message body.
Attachment #8546932 - Flags: review+
Attachment #8546932 - Flags: review?(cajbir.bugzilla)
Attachment #8546932 - Flags: review?(kinetik)
Attachment #8546932 - Flags: review?(karlt)
Attachment #8546932 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/84c65d67215f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8546932 [details] [diff] [review]
Initialize MediaSourceReader::mLast{Audio,Video}Time to 0 rather than -1. v1

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: YouTube video playback stalls, less consistent testing.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. Simple and MSE-specific.
[String/UUID change made/needed]: None.
Attachment #8546932 - Flags: approval-mozilla-beta?
Attachment #8546932 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.