1120047 - conditions for setting HAVE___LIBC_STACK_END in nsStackWalk.cpp seem wrong

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

https://hg.mozilla.org/mozilla-central/file/bb8d6034f5f2/xpcom/base/nsStackWalk.cpp#l878

The condition there looks wrong.  For one, the || probably should be an &&.  Second, the __GLIBC_MINOR should be an __GLIBC_MINOR__.  What's the actual version number check we should be doing?  From a bit of searching, I think it might be ">= 2.1".

When I try with this patch it fails during linking, though.

cam@mintvm32 ~/moz/a $ objdump -T /lib/ld-linux.so.2 | grep stack_end
00020f2c g    DO .data.rel.ro	00000004  GLIBC_2.1   __libc_stack_end
cam@mintvm32 ~/moz/a $ ./mach build
...
 0:36.52 /home/cam/moz/a/xpcom/base/nsStackWalk.cpp:962: error: undefined reference to '__libc_stack_end'
 0:36.52 collect2: error: ld returned 1 exit status

Mike do you know what's going on here?

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 8546974 [details] [diff] [review]
patch

Review of attachment 8546974 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsStackWalk.cpp
@@ +877,5 @@
>  #define HAVE___LIBC_STACK_END 0
>  #endif
>  
>  #if HAVE___LIBC_STACK_END
>  extern void* __libc_stack_end; // from ld-linux.so

This probably needs a MOZ_EXPORT.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: patch (v2)

Thanks, that's exactly what was needed.

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3644e19027a3

Comment 4

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9a5a968a5f3

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f9a5a968a5f3