1120048 - Strange formatting on inline URLs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Peter Bengtsson [:peterbe]]

Best described by looking at this comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1119347#c4

Comment 1

[Peter Bengtsson [:peterbe]]

Testing it again: https://github.com/mozilla/socorro/pull/1886/files#r9722878

Comment 2

[Mark Côté [:mcote]]

You can see the transformation by pasting the URL (as given in the URL field above) into the comment-entry box and then switching to the Preview tab. It always generates the mangled URL seen in comment 1.

Comment 3

[Frédéric Buclin]

This is not an upstream bug. Bugzilla automatically linkifies URLs, but bmo has a customization to also convert rXXXXX into a URL. So both code are trying to linkify the same string. The bmo customization shouldn't try to linkify rXXXXX when it's part of a URL.

Comment 4

[:glob ✱]

Attachment: 1120048_1.patch

it's much easier to to check for whitespace preceding the "r".
there's also no need to html_quote a string which matches \d{4,}

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8552234 [details] [diff] [review]
1120048_1.patch

Review of attachment 8552234 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

I also note this solution is a bit less than ideal, as well.

Comment 7

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   42e7bbf..c8c9ad0  master -> master