Closed Bug 1120051 Opened 7 years ago Closed 7 years ago

Remove nonstandard let block from ForgetAboutSite.jsm

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- unaffected
firefox37 --- affected

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

let blocks are a nonstandard language extension in SpiderMonkey that we would like to remove.
Attachment #8546982 - Flags: review?(dtownsend)
Comment on attachment 8546982 [details] [diff] [review]
remove-let-block.patch

Review of attachment 8546982 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/forgetaboutsite/ForgetAboutSite.jsm
@@ +112,1 @@
>          let list = yield Downloads.getList(Downloads.ALL);

I forgot to mention that I also upgraded this nonstandard legacy generator to an ES6 generator. Legacy generators are another SpiderMonkey language extension we'd like to remove.
Blocks: 1083482
Attachment #8546982 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/78dca438be2f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Blocks: 1167029
You need to log in before you can comment on or make changes to this bug.