MP4: Use movie extend header box's duration if no track duration could be found

RESOLVED FIXED in Firefox 36

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla38
Points:
---
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, firefox38 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We currently only extract the duration from the trak's atom track header. Which may not always exit.

Use the mvex's mehd (Movie Extend Header) if available as fallback.
(Assignee)

Comment 1

4 years ago
Read Movie Extend Header's duration and use as fallback if no track header's duration is defined.
Attachment #8547035 - Flags: review?(ajones)
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
To test:
http://people.mozilla.org/~jyavenard/tests/mse_mp4/gizmo.html?eos=0&eosat=-1&duration=-1&init=1

duration is properly set to 5.534s ... (same as what IE and Chrome are doing)
Attachment #8547035 - Flags: review?(ajones) → review+
(Assignee)

Comment 3

4 years ago
This change was actually required by this mehd change
(Assignee)

Comment 4

4 years ago
Comment on attachment 8550226 [details] [diff] [review]
Update w3c web reference tests

Carrying r+ from bug 1120086 by cajbir
Attachment #8550226 - Flags: review+
(Assignee)

Comment 5

4 years ago
oops, wrong patch uploaded
(Assignee)

Updated

4 years ago
Attachment #8550226 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/0bf6cb3e40dc
https://hg.mozilla.org/mozilla-central/rev/936880d652de
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8547035 [details] [diff] [review]
Use Movie Extend Header's duration as fallback when available

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Risk is relatively low. We parse a new duration field, but only use it in fallback.
[String/UUID change made/needed]: None

This request applies to both patches on this bug.
Attachment #8547035 - Flags: approval-mozilla-beta?
Attachment #8547035 - Flags: approval-mozilla-aurora?
Attachment #8547035 - Flags: approval-mozilla-beta?
Attachment #8547035 - Flags: approval-mozilla-beta+
Attachment #8547035 - Flags: approval-mozilla-aurora?
Attachment #8547035 - Flags: approval-mozilla-aurora+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.