Closed
Bug 1120075
Opened 6 years ago
Closed 6 years ago
MP4: Use movie extend header box's duration if no track duration could be found
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(2 files, 1 obsolete file)
4.59 KB,
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
Details | Diff | Splinter Review |
We currently only extract the duration from the trak's atom track header. Which may not always exit. Use the mvex's mehd (Movie Extend Header) if available as fallback.
Assignee | ||
Comment 1•6 years ago
|
||
Read Movie Extend Header's duration and use as fallback if no track header's duration is defined.
Attachment #8547035 -
Flags: review?(ajones)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•6 years ago
|
||
To test: http://people.mozilla.org/~jyavenard/tests/mse_mp4/gizmo.html?eos=0&eosat=-1&duration=-1&init=1 duration is properly set to 5.534s ... (same as what IE and Chrome are doing)
Updated•6 years ago
|
Attachment #8547035 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 3•6 years ago
|
||
This change was actually required by this mehd change
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8550226 [details] [diff] [review] Update w3c web reference tests Carrying r+ from bug 1120086 by cajbir
Attachment #8550226 -
Flags: review+
Assignee | ||
Comment 5•6 years ago
|
||
oops, wrong patch uploaded
Assignee | ||
Updated•6 years ago
|
Attachment #8550226 -
Attachment is obsolete: true
Assignee | ||
Comment 6•6 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/936880d652de http://hg.mozilla.org/integration/mozilla-inbound/rev/0bf6cb3e40dc
https://hg.mozilla.org/mozilla-central/rev/0bf6cb3e40dc https://hg.mozilla.org/mozilla-central/rev/936880d652de
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 8•6 years ago
|
||
Comment on attachment 8547035 [details] [diff] [review] Use Movie Extend Header's duration as fallback when available Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve flash video. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Risk is relatively low. We parse a new duration field, but only use it in fallback. [String/UUID change made/needed]: None This request applies to both patches on this bug.
Attachment #8547035 -
Flags: approval-mozilla-beta?
Attachment #8547035 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Updated•6 years ago
|
Attachment #8547035 -
Flags: approval-mozilla-beta?
Attachment #8547035 -
Flags: approval-mozilla-beta+
Attachment #8547035 -
Flags: approval-mozilla-aurora?
Attachment #8547035 -
Flags: approval-mozilla-aurora+
Comment 9•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9faf4bb8bb2e https://hg.mozilla.org/releases/mozilla-aurora/rev/56f65f026273 https://hg.mozilla.org/releases/mozilla-beta/rev/18ade4ad787e
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•