1120075 - MP4: Use movie extend header box's duration if no track duration could be found

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

We currently only extract the duration from the trak's atom track header. Which may not always exit.

Use the mvex's mehd (Movie Extend Header) if available as fallback.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Use Movie Extend Header's duration as fallback when available

Read Movie Extend Header's duration and use as fallback if no track header's duration is defined.

Comment 2

[Jean-Yves Avenard [:jya]]

To test:
http://people.mozilla.org/~jyavenard/tests/mse_mp4/gizmo.html?eos=0&eosat=-1&duration=-1&init=1

duration is properly set to 5.534s ... (same as what IE and Chrome are doing)

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Update w3c web reference tests

This change was actually required by this mehd change

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8550226 [details] [diff] [review]
Update w3c web reference tests

Carrying r+ from bug 1120086 by cajbir

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Update w3c web reference tests

oops, wrong patch uploaded

Comment 6

[Jean-Yves Avenard [:jya]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/936880d652de
http://hg.mozilla.org/integration/mozilla-inbound/rev/0bf6cb3e40dc

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0bf6cb3e40dc
https://hg.mozilla.org/mozilla-central/rev/936880d652de

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8547035 [details] [diff] [review]
Use Movie Extend Header's duration as fallback when available

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Risk is relatively low. We parse a new duration field, but only use it in fallback.
[String/UUID change made/needed]: None

This request applies to both patches on this bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9faf4bb8bb2e
https://hg.mozilla.org/releases/mozilla-aurora/rev/56f65f026273

https://hg.mozilla.org/releases/mozilla-beta/rev/18ade4ad787e