1120080 - Check for updates on the about: page is no longer functional

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

From the about: paged, tapping Check For Updates no longer performs and update check.

THis appears to be a regressions from bug 948892.

Comment 1

[Aaron Train [:aaronmt]]

Is there any Gecko related error message on tap? Margaret can you take a look?

Comment 2

[Bill Gianopoulos [:WG9s]]

Where should I look for these errors?  All I know is if I tap Check for updates it never changes to Looking for Updates.

Also if there are updates present they do not download or install.

Comment 3

[Bill Gianopoulos [:WG9s]]

This worked with the 20150108 nightly.

Comment 4

[Bill Gianopoulos [:WG9s]]

I probably would not have made this major were it not uplift day tomorrow.

Comment 5

[Richard Newman [:rnewman]]

[JavaScript Error: "ReferenceError: checkForUpdates is not defined" {file: "about:firefox" line: 1}]

Comment 6

[Richard Newman [:rnewman]]

Indeed, about.js defines checkForUpdates as an inner function of init(), so this looks pretty broken.

"The scope of a function is the function in which it is declared, or the entire program if it is declared at the top level."

Comment 7

[Richard Newman [:rnewman]]

Attachment: Fix about:firefox updater hooks. v1

Testing this now, but this seems like the smallest possible fix.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/2c8cdce4fed4

Comment 9

[:Margaret Leibovic]

Sorry about that, thanks for catching and fixing so quickly.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c8cdce4fed4

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Tapping "Check For Updates" displays the message "downloading update" and I was able to update to latest Nightly (15-01-2015) using  Moto X (Android 4.4) and Samsung Galaxy Tab2 (Android 4.1.2)

Comment 12

[Cristina Madaras, QA [:CristinaM]]

I will mark this as verified fixed based on Teodora's comment 11.