1120124 - Win64 installer defaulting to C:\Program Files (x86)

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

When I installed today's Win64 nightly, the installer provided a default path of c:\Program Files (x86)\Nightly. I already had 32-bit nightly installed; I'm not sure if that was a contributing factor or not...

Comment 1

[Robert Strong (they/them - no direct email)]

I've seen that happen when there was an x64 install in Program Files (x86) due to the code that detects a previous install so new installs install into the same directory. Try uninstalling and then running the installer again.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> I've seen that happen when there was an x64 install in Program Files (x86)
> due to the code that detects a previous install so new installs install into
> the same directory. Try uninstalling and then running the installer again.

Comment 3

[bug.zilla]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> I've seen that happen when there was an x64 install in Program Files (x86)
> due to the code that detects a previous install so new installs install into
> the same directory. Try uninstalling and then running the installer again.

I have the same issue but my existing installation in Program Files (x86) is 32bit

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Attachment: MozReview Request: Bug 1120124 - Prevent 64-bit builds from installing over 32-bit ones (or vice-versa) by default; r?rstrong

Bug 1120124 - Prevent 64-bit builds from installing over 32-bit ones (or vice-versa) by default. r?rstrong

Comment 6

[Jukka Jylänki]

Seeing this as well today. Installed https://ftp.mozilla.org/pub/firefox/releases/latest/win64/en-US/Firefox%20Setup%2042.0.exe and it offered to install to "C:\Program Files (x86)\Firefox", when that location contains a 32-bit stable channel installation.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 8685684 [details]
MozReview Request: Bug 1120124 - Prevent 64-bit builds from installing over 32-bit ones (or vice-versa) by default; r?rstrong

https://reviewboard.mozilla.org/r/24871/#review25361

I believe you can use WordFind as is used elsewhere in the code instead of a custom function.

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8685684 [details]
MozReview Request: Bug 1120124 - Prevent 64-bit builds from installing over 32-bit ones (or vice-versa) by default; r?rstrong

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24871/diff/1-2/

Comment 9

[Robert Strong (they/them - no direct email)]

Comment on attachment 8685684 [details]
MozReview Request: Bug 1120124 - Prevent 64-bit builds from installing over 32-bit ones (or vice-versa) by default; r?rstrong

https://reviewboard.mozilla.org/r/24871/#review26533

Nicely done!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a768e46f4e58

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a768e46f4e58

Comment 13

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
On Windows 7 SP1 x86-64, it is pointing to x86 program files.


Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Actual Results: 
As expected

Expected Results: 
Location of installer by default has not changed.